Bug 780680: Remove never-read variable 'prevGlyphCharIndex' from gfxHarfBuzzShaper::SetGlyphsFromRun(). r=jfkthame
authorDaniel Holbert <dholbert@cs.stanford.edu>
Mon, 06 Aug 2012 13:34:38 -0700
changeset 101570 759748513d641b953378472641da57b04d68d2a2
parent 101569 c80832b8841b1cc4f8e5d4a444684cc834eb0559
child 101571 a6c4661c3ead0be431bcd3a765c58e6e11cbad58
push id13063
push userdholbert@mozilla.com
push dateMon, 06 Aug 2012 20:39:18 +0000
treeherdermozilla-inbound@a6c4661c3ead [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjfkthame
bugs780680
milestone17.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 780680: Remove never-read variable 'prevGlyphCharIndex' from gfxHarfBuzzShaper::SetGlyphsFromRun(). r=jfkthame
gfx/thebes/gfxHarfBuzzShaper.cpp
--- a/gfx/thebes/gfxHarfBuzzShaper.cpp
+++ b/gfx/thebes/gfxHarfBuzzShaper.cpp
@@ -1189,24 +1189,22 @@ gfxHarfBuzzShaper::SetGlyphsFromRun(gfxC
                 // no glyphs, try to extend the clump
                 continue;
             }
 
             // check whether all glyphs in the range are associated with the characters
             // in our clump; if not, we have a discontinuous range, and should extend it
             // unless we've reached the end of the text
             bool allGlyphsAreWithinCluster = true;
-            PRInt32 prevGlyphCharIndex = charStart - 1;
             for (PRInt32 i = glyphStart; i < glyphEnd; ++i) {
                 PRInt32 glyphCharIndex = ginfo[i].cluster;
                 if (glyphCharIndex < charStart || glyphCharIndex >= charEnd) {
                     allGlyphsAreWithinCluster = false;
                     break;
                 }
-                prevGlyphCharIndex = glyphCharIndex;
             }
             if (allGlyphsAreWithinCluster) {
                 break;
             }
         }
 
         NS_ASSERTION(glyphStart < glyphEnd,
                      "character/glyph clump contains no glyphs!");