Bug 819033 - Part 0: Remove references to private xpcshell variables; r=paolo
authorGregory Szorc <gps@mozilla.com>
Tue, 11 Dec 2012 10:53:24 -0800
changeset 115722 7592c22f19ecb86f704a69345e4ad7602a219ae5
parent 115721 1e0fc8c9988fbae74c1572f4891eac4571d4006b
child 115723 fef8ecbe43f5895eb444f74885ab40340f3c2a63
push id19508
push usergszorc@mozilla.com
push dateWed, 12 Dec 2012 01:27:52 +0000
treeherdermozilla-inbound@fef8ecbe43f5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspaolo
bugs819033
milestone20.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 819033 - Part 0: Remove references to private xpcshell variables; r=paolo
browser/components/places/tests/unit/test_browserGlue_prefs.js
toolkit/components/places/tests/unit/test_sql_guid_functions.js
--- a/browser/components/places/tests/unit/test_browserGlue_prefs.js
+++ b/browser/components/places/tests/unit/test_browserGlue_prefs.js
@@ -22,17 +22,17 @@ function waitForImportAndSmartBookmarks(
     Services.obs.removeObserver(waitImport, "bookmarks-restore-success");
     // Delay to test eventual smart bookmarks creation.
     do_execute_soon(function () {
       promiseAsyncUpdates().then(aCallback);
     });
   }, "bookmarks-restore-success", false);
 }
 
-let gTests = [
+[
 
   // This test must be the first one.
   function test_checkPreferences() {
     // Initialize Places through the History Service and check that a new
     // database has been created.
     do_check_eq(PlacesUtils.history.databaseStatus,
                 PlacesUtils.history.DATABASE_STATUS_CREATE);
 
@@ -258,17 +258,17 @@ let gTests = [
     });
     // Force nsBrowserGlue::_initPlaces()
     do_log_info("Simulate Places init");
     bg.QueryInterface(Ci.nsIObserver).observe(null,
                                               TOPIC_BROWSERGLUE_TEST,
                                               TOPICDATA_FORCE_PLACES_INIT);
   }
 
-];
+].forEach(add_test);
 
 do_register_cleanup(function () {
   remove_all_bookmarks();
   remove_bookmarks_html();
   remove_all_JSON_backups();
 });
 
 function run_test()
--- a/toolkit/components/places/tests/unit/test_sql_guid_functions.js
+++ b/toolkit/components/places/tests/unit/test_sql_guid_functions.js
@@ -9,18 +9,17 @@
 /**
  * Checks all our invariants about our guids for a given result.
  *
  * @param aGuid
  *        The guid to check.
  */
 function check_invariants(aGuid)
 {
-  print("TEST-INFO | " + gRunningTest.name + " | Checking guid '" +
-        aGuid + "'");
+  do_print("Checking guid '" + aGuid + "'");
 
   do_check_valid_places_guid(aGuid);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 //// Test Functions
 
 function test_guid_invariants()