Bug 1486690 - Remove an unnecessary NS_FREE_XPCOM_ISUPPORTS_POINTER_ARRAY call. r=glandium
authorNicholas Nethercote <nnethercote@mozilla.com>
Tue, 28 Aug 2018 16:00:05 +1000
changeset 433691 74318e0ebe1ecc477cc9ffb8870420721ecc42f6
parent 433690 8257797fd2d80b0954d44d8eebcb33459a9a569a
child 433692 0da110967e8bd3005d157a1665a9db6cb8c9e0c4
push id107158
push usernnethercote@mozilla.com
push dateWed, 29 Aug 2018 04:31:19 +0000
treeherdermozilla-inbound@74318e0ebe1e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersglandium
bugs1486690
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1486690 - Remove an unnecessary NS_FREE_XPCOM_ISUPPORTS_POINTER_ARRAY call. r=glandium
dom/xslt/xslt/txMozillaXSLTProcessor.cpp
--- a/dom/xslt/xslt/txMozillaXSLTProcessor.cpp
+++ b/dom/xslt/xslt/txMozillaXSLTProcessor.cpp
@@ -1469,21 +1469,16 @@ txVariable::Convert(nsIVariant *aValue, 
 
             NS_ASSERTION(type == nsIDataType::VTYPE_INTERFACE ||
                          type == nsIDataType::VTYPE_INTERFACE_IS,
                          "Huh, we checked this in SetParameter?");
 
             nsISupports** values = static_cast<nsISupports**>(array);
 
             RefPtr<txNodeSet> nodeSet = new txNodeSet(nullptr);
-            if (!nodeSet) {
-                NS_FREE_XPCOM_ISUPPORTS_POINTER_ARRAY(count, values);
-
-                return NS_ERROR_OUT_OF_MEMORY;
-            }
 
             uint32_t i;
             for (i = 0; i < count; ++i) {
                 nsISupports *supports = values[i];
                 nsCOMPtr<nsINode> node = do_QueryInterface(supports);
                 NS_ASSERTION(node, "Huh, we checked this in SetParameter?");
 
                 nsAutoPtr<txXPathNode> xpathNode(