Bug 1207499 - Part 12: Remove use of expression closure from widget/. r=roc
authorTooru Fujisawa <arai_a@mac.com>
Wed, 23 Sep 2015 18:42:20 +0900
changeset 265270 73d2fd0abd3ff2a4fca39c6df3b38fc2cfacd2d3
parent 265269 56d7babc614789c15a3349af2f78b01e44dcafb5
child 265271 056927c667aba841994c8fa970116c4e205007a4
push id65891
push userarai_a@mac.com
push dateWed, 30 Sep 2015 16:36:04 +0000
treeherdermozilla-inbound@10194aec7255 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersroc
bugs1207499
milestone44.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1207499 - Part 12: Remove use of expression closure from widget/. r=roc
widget/tests/bug586713_window.xul
widget/tests/test_bug760802.xul
widget/tests/test_taskbar_progress.xul
--- a/widget/tests/bug586713_window.xul
+++ b/widget/tests/bug586713_window.xul
@@ -39,12 +39,12 @@
       if (fooCallCount == 2) {
         ok(true, "If we got here we didn't crash, excellent.");
         onTestsFinished();
       }
     }
 
     function onLoad() {
       foo();
-      setTimeout(function() foo(), 0);
+      setTimeout(() => foo(), 0);
     }
   ]]></script>
 </window>
--- a/widget/tests/test_bug760802.xul
+++ b/widget/tests/test_bug760802.xul
@@ -46,17 +46,19 @@ function shouldThrowException(fun, excep
     fun.call();
     return false;
   } catch (e) {
     $("display").innerHTML += "<br/>OK thrown: "+e.message;
     return (e instanceof Components.Exception &&
             e.result === exception)
   }
 }
-function doesntThrowException(fun) !shouldThrowException(fun)
+function doesntThrowException(fun) {
+  return !shouldThrowException(fun);
+}
 
 var baseWindow = getBaseWindowInterface(this);
 var nativeHandle = baseWindow.nativeHandle;
 $("display").innerHTML = "found nativeHandle for this window: "+nativeHandle;
 
 var wm = Cc["@mozilla.org/appshell/window-mediator;1"].getService(Ci.nsIWindowMediator);
 var win = wm.getMostRecentWindow("navigator:browser");
 var docShell = getBaseWindowInterfaceFromDocShell(win);
--- a/widget/tests/test_taskbar_progress.xul
+++ b/widget/tests/test_taskbar_progress.xul
@@ -62,17 +62,19 @@
         try {
           progress.setProgressState(s,c,m);
           return false;
         } catch (e) {
           return true;
         }
       }
 
-      function doesntThrow(s,c,m) !shouldThrow(s,c,m)
+      function doesntThrow(s,c,m) {
+        return !shouldThrow(s,c,m);
+      }
 
       ok(doesntThrow(TP.STATE_NO_PROGRESS, 0, 0), "No progress state can be set");
       ok(doesntThrow(TP.STATE_INDETERMINATE, 0, 0), "Indeterminate state can be set");
       ok(doesntThrow(TP.STATE_NORMAL, 0, 0), "Normal state can be set");
       ok(doesntThrow(TP.STATE_ERROR, 0, 0), "Error state can be set");
       ok(doesntThrow(TP.STATE_PAUSED, 0, 0), "Paused state can be set");
 
       ok(shouldThrow(TP.STATE_NO_PROGRESS, 1, 1), "Cannot set no progress with values");