Bug 1333383 - fix netmonitor response tab for json responses with null values;r=jdescottes
authorCosm <kausam2015@gmail.com>
Fri, 27 Jan 2017 16:36:25 +0530
changeset 332429 7305ca850fb34af24a4cc0585e1613ef81bb1390
parent 332428 06c3be84254cd996a4b3830e23b3bc49e8cd1b63
child 332430 713e1811a14ff710f6cf0e5ad2643fb5786ad7e3
push id86529
push userjdescottes@mozilla.com
push dateFri, 03 Feb 2017 15:03:34 +0000
treeherdermozilla-inbound@713e1811a14f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjdescottes
bugs1333383
milestone54.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1333383 - fix netmonitor response tab for json responses with null values;r=jdescottes MozReview-Commit-ID: 2udR3B7uA4h
devtools/client/netmonitor/shared/components/properties-view.js
--- a/devtools/client/netmonitor/shared/components/properties-view.js
+++ b/devtools/client/netmonitor/shared/components/properties-view.js
@@ -107,17 +107,17 @@ const PropertiesView = createClass({
   renderValueWithRep(props) {
     const { member } = props;
 
     // Hide strings with following conditions
     // 1. this row is a togglable section
     // 2. the `value` object has a `value` property, only happend in Cookies panel
     // Put 2 here to not dup this method
     if (member.level === 0 ||
-      (typeof member.value === "object" && member.value.value)) {
+      (typeof member.value === "object" && member.value && member.value.value)) {
       return null;
     }
 
     return Rep(Object.assign(props, {
       // FIXME: A workaround for the issue in StringRep
       // Force StringRep to crop the text everytime
       member: Object.assign({}, member, { open: false }),
       mode: MODE.TINY,