Backed out changeset 23b5cf2c6824 (bug 1457483) for build bustages e.g. OSError: [Errno 13] Permission denied/ make[2]: *** [check-vanilla-allocations] Error 1 on a CLOSED TREE
authorAndreea Pavel <apavel@mozilla.com>
Wed, 16 May 2018 17:51:49 +0300
changeset 418538 71f9465fb8544b37a447efedf4cd8a220ee9b130
parent 418537 14fb6876d99650f5fbcca42c000703fc198abe59
child 418539 54d57adb53fb89d574f515f97a1b024c8fc3641f
push id103323
push usershindli@mozilla.com
push dateWed, 16 May 2018 18:54:02 +0000
treeherdermozilla-inbound@11857580f5e1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1457483
milestone62.0a1
backs out23b5cf2c6824961ffb77a4a1f9d5d0888d678281
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 23b5cf2c6824 (bug 1457483) for build bustages e.g. OSError: [Errno 13] Permission denied/ make[2]: *** [check-vanilla-allocations] Error 1 on a CLOSED TREE
config/check_vanilla_allocations.py
js/src/old-configure.in
old-configure.in
--- a/config/check_vanilla_allocations.py
+++ b/config/check_vanilla_allocations.py
@@ -37,17 +37,16 @@
 #----------------------------------------------------------------------------
 
 from __future__ import print_function
 
 import argparse
 import re
 import subprocess
 import sys
-import buildconfig
 
 # The obvious way to implement this script is to search for occurrences of
 # malloc et al, succeed if none are found, and fail is some are found.
 # However, "none are found" does not necessarily mean "none are present" --
 # this script could be buggy.  (Or the output format of |nm| might change in
 # the future.)
 #
 # So jsutil.cpp deliberately contains a (never-called) function that contains a
@@ -72,18 +71,17 @@ def main():
     parser.add_argument('file', type=str,
                         help='name of the file to check')
     args = parser.parse_args()
 
     # Run |nm|.  Options:
     # -u: show only undefined symbols
     # -C: demangle symbol names
     # -A: show an object filename for each undefined symbol
-    nm = buildconfig.substs.get('NM', 'nm')
-    cmd = [nm, '-u', '-C', '-A', args.file]
+    cmd = ['nm', '-u', '-C', '-A', args.file]
     lines = subprocess.check_output(cmd, universal_newlines=True,
                                     stderr=subprocess.PIPE).split('\n')
 
     # alloc_fns contains all the vanilla allocation/free functions that we look
     # for. Regexp chars are escaped appropriately.
 
     alloc_fns = [
         # Matches |operator new(unsigned T)|, where |T| is |int| or |long|.
--- a/js/src/old-configure.in
+++ b/js/src/old-configure.in
@@ -1682,17 +1682,16 @@ dnl =
 dnl = Maintainer debug option (no --enable equivalent)
 dnl =
 dnl ========================================================
 
 AC_SUBST(AR)
 AC_SUBST(AR_FLAGS)
 AC_SUBST(AR_EXTRACT)
 AC_SUBST(AS)
-AC_SUBST(NM)
 AC_SUBST_LIST(ASFLAGS)
 AC_SUBST(AS_DASH_C_FLAG)
 AC_SUBST(RC)
 AC_SUBST(RCFLAGS)
 AC_SUBST(WINDRES)
 AC_SUBST(IMPLIB)
 AC_SUBST(FILTER)
 AC_SUBST_LIST(MOZ_DEBUG_LDFLAGS)
--- a/old-configure.in
+++ b/old-configure.in
@@ -4054,17 +4054,16 @@ dnl =
 dnl = Maintainer debug option (no --enable equivalent)
 dnl =
 dnl ========================================================
 
 AC_SUBST(AR)
 AC_SUBST(AR_FLAGS)
 AC_SUBST(AR_EXTRACT)
 AC_SUBST(AS)
-AC_SUBST(NM)
 AC_SUBST_LIST(ASFLAGS)
 AC_SUBST(AS_DASH_C_FLAG)
 AC_SUBST(RC)
 AC_SUBST(RCFLAGS)
 AC_SUBST(WINDRES)
 AC_SUBST(IMPLIB)
 AC_SUBST(FILTER)
 AC_SUBST(MOZ_AUTH_EXTENSION)