Bug 1198331 - Titles in sidebar aren't cropped and cross borders between tabs (titles are to long in some locales). r=pbrosset
authorRaphaël Lustin <raphael@lustin.fr>
Mon, 28 Sep 2015 15:25:00 +0200
changeset 265674 6e82a342d591890dbec410240fd4133a007a8038
parent 265673 313b18c6256653499cf1296de18a90ab2817506f
child 265675 32dc4f8f3aa0def426ec4745a402981050a8a6c8
push id66003
push usercbook@mozilla.com
push dateFri, 02 Oct 2015 11:37:40 +0000
treeherdermozilla-inbound@3fd732d24f46 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspbrosset
bugs1198331
milestone44.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1198331 - Titles in sidebar aren't cropped and cross borders between tabs (titles are to long in some locales). r=pbrosset
devtools/client/framework/sidebar.js
devtools/client/netmonitor/netmonitor.xul
--- a/devtools/client/framework/sidebar.js
+++ b/devtools/client/framework/sidebar.js
@@ -220,16 +220,17 @@ ToolSidebar.prototype = {
     iframe.setAttribute("src", url);
     iframe.tooltip = "aHTMLTooltip";
 
     // Creating the tab and adding it to the tabbox
     let tab = this._panelDoc.createElementNS(XULNS, "tab");
     this._tabbox.tabs.appendChild(tab);
     tab.setAttribute("label", ""); // Avoid showing "undefined" while the tab is loading
     tab.setAttribute("id", this.TAB_ID_PREFIX + id);
+    tab.setAttribute("crop", "end");
 
     // Add the tab to the allTabs menu if exists
     let allTabsItem = this._addItemToAllTabsMenu(id, tab, selected);
 
     let onIFrameLoaded = (event) => {
       let doc = event.target;
       let win = doc.defaultView;
       tab.setAttribute("label", doc.title);
--- a/devtools/client/netmonitor/netmonitor.xul
+++ b/devtools/client/netmonitor/netmonitor.xul
@@ -314,28 +314,35 @@
                        data-key="body"/>
             </vbox>
           </vbox>
           <tabbox id="event-details-pane"
                   class="devtools-sidebar-tabs"
                   handleCtrlTab="false">
             <tabs>
               <tab id="headers-tab"
+                   crop="end"
                    label="&netmonitorUI.tab.headers;"/>
               <tab id="cookies-tab"
+                   crop="end"
                    label="&netmonitorUI.tab.cookies;"/>
               <tab id="params-tab"
+                   crop="end"
                    label="&netmonitorUI.tab.params;"/>
               <tab id="response-tab"
+                   crop="end"
                    label="&netmonitorUI.tab.response;"/>
               <tab id="timings-tab"
+                   crop="end"
                    label="&netmonitorUI.tab.timings;"/>
               <tab id="security-tab"
+                   crop="end"
                    label="&netmonitorUI.tab.security;"/>
               <tab id="preview-tab"
+                   crop="end"
                    label="&netmonitorUI.tab.preview;"/>
             </tabs>
             <tabpanels flex="1">
               <tabpanel id="headers-tabpanel"
                         class="tabpanel-content">
                 <vbox flex="1">
                   <hbox id="headers-summary-url"
                         class="tabpanel-summary-container"