Backed out changeset 916db80793cb (bug 1497784) for web platform tests failures on /_mozilla/binast/large.https.html. CLOSED TREE
authorCsoregi Natalia <ncsoregi@mozilla.com>
Tue, 30 Oct 2018 04:19:45 +0200
changeset 443437 6e4537056d5363fc118fa946615955798892314b
parent 443436 e37bf786b5fcbf048cefbea44a85783a68ce4339
child 443438 93b0ecc96c2366b5f171f23571a81c0d0ef71bb4
child 443465 77a0119f67daa4a2b665734fabfa60b372d5610a
push id109377
push userncsoregi@mozilla.com
push dateTue, 30 Oct 2018 02:20:01 +0000
treeherdermozilla-inbound@6e4537056d53 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1497784
milestone65.0a1
backs out916db80793cbefc667b019edefeb83559c535b50
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 916db80793cb (bug 1497784) for web platform tests failures on /_mozilla/binast/large.https.html. CLOSED TREE
js/src/frontend/BinSource-auto.cpp
js/src/frontend/BinSource.yaml
js/src/jsapi-tests/binast/parser/multipart/unit/let_in_fun.binjs
js/src/jsapi-tests/binast/parser/multipart/unit/let_in_fun.js
--- a/js/src/frontend/BinSource-auto.cpp
+++ b/js/src/frontend/BinSource-auto.cpp
@@ -3626,26 +3626,20 @@ BinASTParser<Tok>::parseInterfaceForInOf
 
     BINJS_MOZ_TRY_DECL(kind_, parseVariableDeclarationKind());
 
     BINJS_MOZ_TRY_DECL(binding, parseBinding());
 
     // Restored by `kindGuard`.
     variableDeclarationKind_ = kind_;
     MOZ_TRY(checkBinding(binding->template as<NameNode>().atom()->asPropertyName()));
-    ParseNodeKind pnk;
-    switch (kind_) {
-      case VariableDeclarationKind::Var:
-        pnk = ParseNodeKind::Var;
-        break;
-      case VariableDeclarationKind::Let:
-        return raiseError("Let is not supported in this preview release");
-      case VariableDeclarationKind::Const:
-        return raiseError("Const is not supported in this preview release");
-    }
+    auto pnk =
+        kind_ == VariableDeclarationKind::Let
+            ? ParseNodeKind::Let
+            : ParseNodeKind::Var;
     BINJS_TRY_DECL(result, factory_.newDeclarationList(pnk, tokenizer_->pos(start)));
     factory_.addList(result, binding);
     return result;
 }
 
 template<typename Tok> JS::Result<ParseNode*>
 BinASTParser<Tok>::parseInterfaceForInStatement(const size_t start, const BinKind kind, const BinFields& fields)
 {
@@ -5008,19 +5002,21 @@ BinASTParser<Tok>::parseInterfaceVariabl
     }
 
     ParseNodeKind pnk;
     switch (kind_) {
       case VariableDeclarationKind::Var:
         pnk = ParseNodeKind::Var;
         break;
       case VariableDeclarationKind::Let:
-        return raiseError("Let is not supported in this preview release");
+        pnk = ParseNodeKind::Let;
+        break;
       case VariableDeclarationKind::Const:
-        return raiseError("Const is not supported in this preview release");
+        pnk = ParseNodeKind::Const;
+        break;
     }
     declarators->setKind(pnk);
     auto result = declarators;
     return result;
 }
 
 
 /*
--- a/js/src/frontend/BinSource.yaml
+++ b/js/src/frontend/BinSource.yaml
@@ -839,26 +839,20 @@ ExpressionStatement:
 
 ForInOfBinding:
     init:
         AutoVariableDeclarationKind kindGuard(this);
     build: |
         // Restored by `kindGuard`.
         variableDeclarationKind_ = kind_;
         MOZ_TRY(checkBinding(binding->template as<NameNode>().atom()->asPropertyName()));
-        ParseNodeKind pnk;
-        switch (kind_) {
-          case VariableDeclarationKind::Var:
-            pnk = ParseNodeKind::Var;
-            break;
-          case VariableDeclarationKind::Let:
-            return raiseError("Let is not supported in this preview release");
-          case VariableDeclarationKind::Const:
-            return raiseError("Const is not supported in this preview release");
-        }
+        auto pnk =
+            kind_ == VariableDeclarationKind::Let
+                ? ParseNodeKind::Let
+                : ParseNodeKind::Var;
         BINJS_TRY_DECL(result, factory_.newDeclarationList(pnk, tokenizer_->pos(start)));
         factory_.addList(result, binding);
 
 
 
 ForInStatement:
     init: |
         ParseContext::Statement stmt(parseContext_, StatementKind::ForInLoop);
@@ -1334,19 +1328,21 @@ VariableDeclaration:
         }
 
         ParseNodeKind pnk;
         switch (kind_) {
           case VariableDeclarationKind::Var:
             pnk = ParseNodeKind::Var;
             break;
           case VariableDeclarationKind::Let:
-            return raiseError("Let is not supported in this preview release");
+            pnk = ParseNodeKind::Let;
+            break;
           case VariableDeclarationKind::Const:
-            return raiseError("Const is not supported in this preview release");
+            pnk = ParseNodeKind::Const;
+            break;
         }
         declarators->setKind(pnk);
         auto result = declarators;
 
 VariableDeclarator:
     build: |
         ParseNode* result;
         if (binding->isKind(ParseNodeKind::Name)) {
new file mode 100644
index 0000000000000000000000000000000000000000..5b6d505c434d6a64ca5239ca0ce4bdd67085bbb7
GIT binary patch
literal 393
zc${63K}!QM5QWE3N-0G|M8s1mA|4cqR}a$awp7|xc8izdA<d3;Ae)rQRO)Z`;!iNP
ztQ7-+nR(y57t$Z454oBRv)*LV%U-BJCnO&?pX&6Y7Xq?iagWAo#v;`vcKYNBa*NRh
zd?jSKthgu5kr3qE_$6Lf<J>SUWoZ3e+l|t$lxMv~yNO;P4_3|ydAE(zKV^I1xzzU8
zICLxMktZl`zPR&F;!8qzOi|Z1U6sgWlJ$}?gb22_@#is%^xWbf_p|>q&$E1*jnZMh
z`-pL~X{jV>2nMNJl#cW6%6J!~ZE;OT+xola*)&U%-PZi5p+GeNK(*pk00&S9*xQF%
SGd8hQ$2E1L;1D+F>-HO*X@e>N
new file mode 100644
--- /dev/null
+++ b/js/src/jsapi-tests/binast/parser/multipart/unit/let_in_fun.js
@@ -0,0 +1,3 @@
+function test() {
+    let limit = 1;
+}