Bug 1208316 - Do not stop the local MediaStream in mediaStreamPlayback.js. r=jib
authorAndreas Pehrson <pehrsons@gmail.com>
Fri, 09 Sep 2016 14:21:32 +0200
changeset 320484 6e19f844b55e58b50cdb6ffd8bb65bc3355cf70c
parent 320483 813197b7e9853a7562824f210f4dab9b82b19089
child 320485 5dd1f3da33d9c7657b4bca9f4f9b76fb495a9fb8
push id83396
push userpehrsons@gmail.com
push dateWed, 02 Nov 2016 10:04:27 +0000
treeherdermozilla-inbound@8e63884e4c09 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjib
bugs1208316
milestone52.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1208316 - Do not stop the local MediaStream in mediaStreamPlayback.js. r=jib No need to do this since a media element playing the stream will now end when all tracks have ended. MozReview-Commit-ID: DXPY3G36gkw
dom/media/tests/mochitest/mediaStreamPlayback.js
--- a/dom/media/tests/mochitest/mediaStreamPlayback.js
+++ b/dom/media/tests/mochitest/mediaStreamPlayback.js
@@ -62,22 +62,16 @@ MediaStreamPlayback.prototype = {
         haveEvent(t, "ended", onNextLoop)
           .then(() => Promise.reject("Unexpected ended event for track " + t.id),
                 () => Promise.resolve())
       ]);
       t.stop();
       return p;
     }));
 
-    // XXX (bug 1208316) When we implement MediaStream.active, do not stop
-    // the stream. We just do it now so the media element will raise 'ended'.
-    if (!this.mediaStream.stop) {
-      return;
-    }
-    this.mediaStream.stop();
     return timeout(waitForEnded(), ENDED_TIMEOUT_LENGTH, "ended event never fired")
              .then(() => ok(true, "ended event successfully fired"))
              .then(() => noTrackEnded);
   },
 
   /**
    * Starts media with a media stream, runs it until a canplaythrough and
    * timeupdate event fires, and detaches from the element without stopping media.