No bug: [taskgraph] Remove `check_servo` filter; r=dustin
authorTom Prince <mozilla@hocat.ca>
Thu, 25 Oct 2018 18:32:09 +0000
changeset 443039 6c2ca1a524e6c126f25979c39f3ee9627efd3746
parent 443038 91ab8acb16b28b2c167b4d28c0a068ca8fa001ca
child 443040 f08bde3d7956c7857dd2c0f50ebbbd895c0b386b
push id109284
push userccoroiu@mozilla.com
push dateThu, 25 Oct 2018 22:04:16 +0000
treeherdermozilla-inbound@d197f134bdc0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdustin
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
No bug: [taskgraph] Remove `check_servo` filter; r=dustin The service hasn't been running for over a year now. Differential Revision: https://phabricator.services.mozilla.com/D9812
taskcluster/taskgraph/decision.py
taskcluster/taskgraph/filter_tasks.py
taskcluster/taskgraph/parameters.py
--- a/taskcluster/taskgraph/decision.py
+++ b/taskcluster/taskgraph/decision.py
@@ -202,17 +202,16 @@ def get_decision_parameters(config, opti
         'comm_head_ref',
     ):
         if n in options and options[n] is not None:
             parameters[n] = options[n]
 
     # Define default filter list, as most configurations shouldn't need
     # custom filters.
     parameters['filters'] = [
-        'check_servo',
         'target_tasks_method',
     ]
     parameters['existing_tasks'] = {}
     parameters['do_not_optimize'] = []
     parameters['build_number'] = 1
     parameters['version'] = get_version(product_dir)
     parameters['app_version'] = get_app_version(product_dir)
     parameters['next_version'] = None
--- a/taskcluster/taskgraph/filter_tasks.py
+++ b/taskcluster/taskgraph/filter_tasks.py
@@ -28,40 +28,8 @@ def filter_target_tasks(graph, parameter
     """Proxy filter to use legacy target tasks code.
 
     This should go away once target_tasks are converted to filters.
     """
 
     attr = parameters.get('target_tasks_method', 'all_tasks')
     fn = target_tasks.get_method(attr)
     return fn(graph, parameters, graph_config)
-
-
-@filter_task('check_servo')
-def filter_servo(graph, parameters, graph_config):
-    """Filter out tasks for Servo vendoring changesets.
-
-    If the change triggering is related to Servo vendoring, impact is minimal
-    because not all platforms use Servo code.
-
-    We filter out tests on platforms that don't run Servo tests because running
-    tests will accomplish little for these changes.
-    """
-
-    SERVO_TEST_PLATFORMS = {
-        'linux64',
-        'linux64-stylo',
-    }
-
-    def fltr(task):
-        if parameters.get('owner') != "servo-vcs-sync@mozilla.com":
-            return True
-
-        # This is a Servo vendor change.
-
-        # Servo code is compiled. So we at least need to build. Resource
-        # savings come from pruning tests. So that's where we filter.
-        if task.attributes.get('kind') != 'test':
-            return True
-
-        return task.attributes.get('build_platform') in SERVO_TEST_PLATFORMS
-
-    return [l for l, t in graph.tasks.iteritems() if fltr(t)]
--- a/taskcluster/taskgraph/parameters.py
+++ b/taskcluster/taskgraph/parameters.py
@@ -50,17 +50,17 @@ def get_app_version(product_dir='browser
 # Parameters are of the form: {name: default}
 PARAMETERS = {
     'app_version': get_app_version(),
     'base_repository': 'https://hg.mozilla.org/mozilla-unified',
     'build_date': lambda: int(time.time()),
     'build_number': 1,
     'do_not_optimize': [],
     'existing_tasks': {},
-    'filters': ['check_servo', 'target_tasks_method'],
+    'filters': ['target_tasks_method'],
     'head_ref': get_head_ref,
     'head_repository': 'https://hg.mozilla.org/mozilla-central',
     'head_rev': get_head_ref,
     'level': '3',
     'message': '',
     'moz_build_date': lambda: datetime.now().strftime("%Y%m%d%H%M%S"),
     'next_version': None,
     'optimize_target_tasks': True,