Bug 1580129 - Add COMPOSITE_TIME metric for geckoview_streaming telemetry. r=Dexter,chutten
authorJamie Nicol <jnicol@mozilla.com>
Tue, 24 Sep 2019 22:13:49 +0000
changeset 494956 6b99299f84d49102c5f1f68d3606f1ce8cc0bda5
parent 494955 aa7f20ae769925c032b117c1b4cc7c3db1f16780
child 494957 59dd2996a78eae7bc065769034cac28c32d5d83f
push id114131
push userdluca@mozilla.com
push dateThu, 26 Sep 2019 09:47:34 +0000
treeherdermozilla-inbound@1dc1a755079a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersDexter, chutten
bugs1580129
milestone71.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1580129 - Add COMPOSITE_TIME metric for geckoview_streaming telemetry. r=Dexter,chutten Differential Revision: https://phabricator.services.mozilla.com/D46920
toolkit/components/telemetry/Histograms.json
toolkit/components/telemetry/geckoview/streaming/metrics.yaml
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -314,25 +314,25 @@
     "kind": "exponential",
     "high": 64000,
     "n_buckets": 100,
     "releaseChannelCollection": "opt-out",
     "description": "Time spent in the generic child process launching code, which is run off-main-thread and used by all child process types"
   },
   "COMPOSITE_TIME" : {
     "record_in_processes": ["main", "content", "gpu"],
-    "products": ["firefox", "fennec", "geckoview"],
-    "alert_emails": ["gfx-telemetry-alerts@mozilla.com", "rhunt@mozilla.com"],
+    "products": ["firefox", "fennec", "geckoview", "geckoview_streaming"],
+    "alert_emails": ["gfx-telemetry-alerts@mozilla.com", "jnicol@mozilla.com"],
     "expires_in_version": "never",
     "description": "Composite times in milliseconds",
     "kind": "exponential",
     "high": 1000,
     "n_buckets": 50,
     "releaseChannelCollection": "opt-out",
-    "bug_numbers": [1080160, 1529352]
+    "bug_numbers": [1080160, 1529352, 1580129]
   },
   "COMPOSITE_FRAME_ROUNDTRIP_TIME" : {
     "record_in_processes": ["main", "content", "gpu"],
     "products": ["firefox", "fennec", "geckoview"],
     "alert_emails": ["gfx-telemetry-alerts@mozilla.com", "rhunt@mozilla.com"],
     "expires_in_version": "never",
     "description": "Time from vsync to finishing a composite in milliseconds.",
     "kind": "exponential",
--- a/toolkit/components/telemetry/geckoview/streaming/metrics.yaml
+++ b/toolkit/components/telemetry/geckoview/streaming/metrics.yaml
@@ -1,9 +1,29 @@
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-
-# This file defines the metrics that are recorded by the Glean SDK. They are
-# automatically converted to platform-specific code at build time using the
-# `glean_parser` PyPI package.
-
-$schema: moz://mozilla.org/schemas/glean/metrics/1-0-0
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
+# This file defines the metrics that are recorded by the Glean SDK. They are
+# automatically converted to platform-specific code at build time using the
+# `glean_parser` PyPI package.
+
+$schema: moz://mozilla.org/schemas/glean/metrics/1-0-0
+
+gfx:
+  composite_time:
+    type: timing_distribution
+    time_unit: millisecond
+    gecko_datapoint: COMPOSITE_TIME
+    description: |
+      The time taken to composite a frame.
+      On non-webrender this is the time taken in `CompositorBridgeParent::CompositeToTarget()`.
+      On webrender, this is the time taken from the start of `WebRenderBridgeParent::CompositeToTarget()`, until the render thread has rendered the frame (in `RenderThread::HandleFrameOneDoc()`).
+    bugs:
+      - 1080160
+      - 1529352
+      - 1580129
+    data_reviews:
+      - https://bugzilla.mozilla.org/show_bug.cgi?id=1580129#c7
+    notification_emails:
+      - gfx-telemetry-alerts@mozilla.com
+      - jnicol@mozilla.com
+    expires: never