Backed out changeset 1fb9356c0a94 (bug 1594885) for devtools failures at browser_toolbox_tools_per_toolbox_registration.js on a CLOSED TREE.
authorGurzau Raul <rgurzau@mozilla.com>
Thu, 14 Nov 2019 03:53:42 +0200
changeset 501874 697506c8c54e4a01e1355fbf967b9a52bd656f6e
parent 501873 cb4ea31e85939ad29c536e0f1e360a244a982482
child 501875 15e1d046f2905279d6f0f151919a07231f0676ac
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1594885
milestone72.0a1
backs out1fb9356c0a94cc9af715fd0ffd9fc21796029628
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 1fb9356c0a94 (bug 1594885) for devtools failures at browser_toolbox_tools_per_toolbox_registration.js on a CLOSED TREE.
browser/app/profile/firefox.js
devtools/client/definitions.js
devtools/client/framework/test/browser_toolbox_toolbar_reorder_by_dnd.js
devtools/client/framework/test/browser_toolbox_toolbar_reorder_with_extension.js
devtools/client/framework/test/browser_toolbox_toolbar_reorder_with_hidden_extension.js
devtools/client/jar.mn
devtools/client/moz.build
devtools/client/whats-new/index.html
devtools/client/whats-new/moz.build
devtools/client/whats-new/panel.js
devtools/client/whats-new/src/base.css
devtools/client/whats-new/src/main.js
devtools/client/whats-new/src/moz.build
devtools/client/whats-new/src/whats-new.css
toolkit/components/telemetry/Events.yaml
--- a/browser/app/profile/firefox.js
+++ b/browser/app/profile/firefox.js
@@ -2333,17 +2333,10 @@ pref("devtools.popup.disable_autohide", 
 
 // Load the DevTools toolbox in a frame with type=content instead of type=chrome
 // See Bug 1539979 for more details.
 // We keep the option of running devtools in a chrome frame while we fix racy
 // tests that started failing when using type=content, but this ultimately
 // should be removed.
 pref("devtools.toolbox.content-frame", true);
 
-// Visibility switch preference for the WhatsNew panel.
-pref("devtools.whatsnew.enabled", true);
-
-// Temporary preference to fully disable the WhatsNew panel on any target.
-// Should be removed in https://bugzilla.mozilla.org/show_bug.cgi?id=1596037
-pref("devtools.whatsnew.feature-enabled", true);
-
 // FirstStartup service time-out in ms
 pref("first-startup.timeout", 30000);
--- a/devtools/client/definitions.js
+++ b/devtools/client/definitions.js
@@ -70,21 +70,16 @@ loader.lazyGetter(
 );
 loader.lazyGetter(
   this,
   "ApplicationPanel",
   () => require("devtools/client/application/panel").ApplicationPanel
 );
 loader.lazyGetter(
   this,
-  "WhatsNewPanel",
-  () => require("devtools/client/whats-new/panel").WhatsNewPanel
-);
-loader.lazyGetter(
-  this,
   "reloadAndRecordTab",
   () => require("devtools/client/webreplay/menu.js").reloadAndRecordTab
 );
 loader.lazyGetter(
   this,
   "reloadAndStopRecordingTab",
   () => require("devtools/client/webreplay/menu.js").reloadAndStopRecordingTab
 );
@@ -472,68 +467,29 @@ Tools.application = {
     return target.isLocalTab;
   },
 
   build: function(iframeWindow, toolbox) {
     return new ApplicationPanel(iframeWindow, toolbox);
   },
 };
 
-Tools.whatsnew = {
-  id: "whatsnew",
-  ordinal: 12,
-  visibilityswitch: "devtools.whatsnew.enabled",
-  icon: "chrome://browser/skin/whatsnew.svg",
-  url: "chrome://devtools/content/whats-new/index.html",
-  // TODO: This panel is currently for english users only.
-  // This should be properly localized in Bug 1596038
-  label: "What’s New",
-  panelLabel: "What’s New",
-  tooltip: "What’s New",
-  inMenu: false,
-
-  isTargetSupported: function(target) {
-    // The panel is currently not localized and should only be displayed to
-    // english users. See Bug 1596038 for cleanup.
-    const isEnglishUser = Services.locale.negotiateLanguages(
-      ["en"],
-      [Services.locale.appLocaleAsBCP47]
-    ).length;
-
-    // In addition to the basic visibility switch preference, we also have a
-    // higher level preference to disable the whole panel regardless of other
-    // settings. Should be removed in Bug 1596037.
-    const isFeatureEnabled = Services.prefs.getBoolPref(
-      "devtools.whatsnew.feature-enabled",
-      false
-    );
-
-    // This panel should only be enabled for regular web toolboxes.
-    return target.isLocalTab && isEnglishUser && isFeatureEnabled;
-  },
-
-  build: function(iframeWindow, toolbox) {
-    return new WhatsNewPanel(iframeWindow, toolbox);
-  },
-};
-
 var defaultTools = [
   Tools.options,
   Tools.webConsole,
   Tools.inspector,
   Tools.jsdebugger,
   Tools.styleEditor,
   Tools.performance,
   Tools.netMonitor,
   Tools.storage,
   Tools.memory,
   Tools.dom,
   Tools.accessibility,
   Tools.application,
-  Tools.whatsnew,
 ];
 
 exports.defaultTools = defaultTools;
 
 Tools.darkTheme = {
   id: "dark",
   label: l10n("options.darkTheme.label2"),
   ordinal: 1,
--- a/devtools/client/framework/test/browser_toolbox_toolbar_reorder_by_dnd.js
+++ b/devtools/client/framework/test/browser_toolbox_toolbar_reorder_by_dnd.js
@@ -114,20 +114,16 @@ const TEST_DATA = [
       "storage",
       "accessibility",
       "webconsole",
     ],
   },
 ];
 
 add_task(async function() {
-  // Temporarily disable the panel added in Bug 1594885.
-  // Should be cleaned up when the panel is properly implemented.
-  await pushPref("devtools.whatsnew.enabled", false);
-
   const tab = await addTab("about:blank");
   const toolbox = await openToolboxForTab(
     tab,
     "inspector",
     Toolbox.HostType.BOTTOM
   );
 
   const originalPreference = Services.prefs.getCharPref(
--- a/devtools/client/framework/test/browser_toolbox_toolbar_reorder_with_extension.js
+++ b/devtools/client/framework/test/browser_toolbox_toolbar_reorder_with_extension.js
@@ -18,20 +18,16 @@ const TEST_STARTING_ORDER = [
   "memory",
   "netmonitor",
   "storage",
   "accessibility",
   EXTENSION,
 ];
 
 add_task(async function() {
-  // Temporarily disable the panel added in Bug 1594885.
-  // Should be cleaned up when the panel is properly implemented.
-  await pushPref("devtools.whatsnew.enabled", false);
-
   const extension = ExtensionTestUtils.loadExtension({
     useAddonManager: "temporary",
     manifest: {
       devtools_page: "extension.html",
       applications: {
         gecko: { id: EXTENSION },
       },
     },
--- a/devtools/client/framework/test/browser_toolbox_toolbar_reorder_with_hidden_extension.js
+++ b/devtools/client/framework/test/browser_toolbox_toolbar_reorder_with_hidden_extension.js
@@ -126,20 +126,16 @@ const TEST_DATA = [
       "accessibility",
       EXTENSION,
       "webconsole",
     ],
   },
 ];
 
 add_task(async function() {
-  // Temporarily disable the panel added in Bug 1594885.
-  // Should be cleaned up when the panel is properly implemented.
-  await pushPref("devtools.whatsnew.enabled", false);
-
   registerCleanupFunction(() => {
     Services.prefs.clearUserPref("devtools.toolbox.tabsOrder");
   });
 
   const extension = ExtensionTestUtils.loadExtension({
     useAddonManager: "temporary",
     manifest: {
       devtools_page: "extension.html",
--- a/devtools/client/jar.mn
+++ b/devtools/client/jar.mn
@@ -237,11 +237,8 @@ devtools.jar:
     content/netmonitor/src/assets/icons/blocked.svg (netmonitor/src/assets/icons/blocked.svg)
     content/netmonitor/index.html (netmonitor/index.html)
     content/netmonitor/src/assets/styles/StatusCode.css (netmonitor/src/assets/styles/StatusCode.css)
     content/netmonitor/src/assets/styles/websockets.css (netmonitor/src/assets/styles/websockets.css)
     content/netmonitor/src/assets/styles/search.css (netmonitor/src/assets/styles/search.css)
 
     # Application panel
     content/application/index.html (application/index.html)
-
-    # WhatsNew panel
-    content/whats-new/index.html (whats-new/index.html)
--- a/devtools/client/moz.build
+++ b/devtools/client/moz.build
@@ -23,17 +23,16 @@ DIRS += [
     'preferences',
     'responsive',
     'shared',
     'storage',
     'styleeditor',
     'themes',
     'webconsole',
     'webreplay',
-    'whats-new',
 ]
 
 JAR_MANIFESTS += ['jar.mn']
 
 DevToolsModules(
     'definitions.js',
     'menus.js',
 )
deleted file mode 100644
--- a/devtools/client/whats-new/index.html
+++ /dev/null
@@ -1,31 +0,0 @@
-<!-- This Source Code Form is subject to the terms of the Mozilla Public
-   - License, v. 2.0. If a copy of the MPL was not distributed with this
-   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
-<!DOCTYPE html>
-<html dir="">
-<head>
-  <link rel="stylesheet" href="resource://devtools/client/whats-new/src/whats-new.css"/>
-  <script src="chrome://devtools/content/shared/theme-switching.js"></script>
-</head>
-
-<body>
-  <script>
-    "use strict";
-    try {
-      const { BrowserLoader } = ChromeUtils.import(
-        "resource://devtools/client/shared/browser-loader.js"
-      );
-      const { require } = BrowserLoader({
-        baseURI: "resource://devtools/client/whats-new",
-        window
-      });
-      window.WhatsNew = require("devtools/client/whats-new/src/main");
-    } catch (e) {
-      dump("Exception happened while loading the whats new panel:\n");
-      dump(e + "\n");
-      dump(e.stack + "\n");
-    }
-  </script>
-  <div id="root"></div>
-</body>
-</html>
deleted file mode 100644
--- a/devtools/client/whats-new/moz.build
+++ /dev/null
@@ -1,11 +0,0 @@
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-
-DevToolsModules(
-    'panel.js'
-)
-
-DIRS += [
-    'src'
-]
deleted file mode 100644
--- a/devtools/client/whats-new/panel.js
+++ /dev/null
@@ -1,26 +0,0 @@
-/* This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */
-
-"use strict";
-
-function WhatsNewPanel(iframeWindow, toolbox) {
-  this.panelWin = iframeWindow;
-  this.toolbox = toolbox;
-}
-
-WhatsNewPanel.prototype = {
-  open: async function() {
-    this.panelWin.WhatsNew.bootstrap();
-    this.emit("ready");
-    this.isReady = true;
-    return this;
-  },
-
-  destroy: function() {
-    this.panelWin.WhatsNew.destroy();
-    this.emit("destroyed");
-  },
-};
-
-exports.WhatsNewPanel = WhatsNewPanel;
deleted file mode 100644
--- a/devtools/client/whats-new/src/base.css
+++ /dev/null
@@ -1,5 +0,0 @@
-/* This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-
-/* base.css */
deleted file mode 100644
--- a/devtools/client/whats-new/src/main.js
+++ /dev/null
@@ -1,10 +0,0 @@
-/* This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */
-
-"use strict";
-
-module.exports = {
-  bootstrap: () => {},
-  destroy: () => {},
-};
deleted file mode 100644
--- a/devtools/client/whats-new/src/moz.build
+++ /dev/null
@@ -1,9 +0,0 @@
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-
-DevToolsModules(
-    'base.css',
-    'main.js',
-    'whats-new.css'
-)
deleted file mode 100644
--- a/devtools/client/whats-new/src/whats-new.css
+++ /dev/null
@@ -1,5 +0,0 @@
-/* This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-
-/* whats-new.css */
--- a/toolkit/components/telemetry/Events.yaml
+++ b/toolkit/components/telemetry/Events.yaml
@@ -1071,17 +1071,17 @@ devtools.main:
       - "geckoview"
     record_in_processes: ["main"]
     description: User is editing a CSS rule by clicking on or next to a CSS property, enabling / disabling a rule or creating a new property.
     release_channel_collection: opt-out
     expiry_version: never
     extra_keys:
       session_id: The start time of the session in milliseconds since epoch (Unix Timestamp) e.g. 1396381378123.
   enter:
-    objects: ["accessibility", "application", "dom", "inspector", "jsdebugger", "memory", "netmonitor", "options", "performance", "storage", "styleeditor", "webconsole", "whatsnew","other", "fakeTool4242", "testBlankPanel", "testTool", "testtool1", "testTool1072208", "testtool2"]
+    objects: ["accessibility", "application", "dom", "inspector", "jsdebugger", "memory", "netmonitor", "options", "performance", "storage", "styleeditor", "webconsole", "other", "fakeTool4242", "testBlankPanel", "testTool", "testtool1", "testTool1072208", "testtool2"]
     bug_numbers: [1441070]
     notification_emails: ["dev-developer-tools@lists.mozilla.org", "hkirschner@mozilla.com"]
     products:
       - "firefox"
       - "fennec"
       - "geckoview"
     record_in_processes: ["main"]
     description: User opens a tool in the devtools toolbox.
@@ -1107,17 +1107,17 @@ devtools.main:
     description: User has executed some JS in the Web Console.
     release_channel_collection: opt-out
     expiry_version: never
     extra_keys:
       input: Indicates from which input the command was evaluated ("inline" for regular input, "multiline" for editor mode).
       lines: The number of lines contained in the command.
       session_id: The start time of the session in milliseconds since epoch (Unix Timestamp) e.g. 1396381378123.
   exit:
-    objects: ["accessibility", "application", "dom", "inspector", "jsdebugger", "memory", "netmonitor", "options", "performance", "storage", "styleeditor", "webconsole", "whatsnew", "other", "fakeTool4242", "testBlankPanel", "testTool", "testtool1", "testTool1072208", "testtool2"]
+    objects: ["accessibility", "application", "dom", "inspector", "jsdebugger", "memory", "netmonitor", "options", "performance", "storage", "styleeditor", "webconsole", "other", "fakeTool4242", "testBlankPanel", "testTool", "testtool1", "testTool1072208", "testtool2"]
     bug_numbers: [1455270]
     notification_emails: ["dev-developer-tools@lists.mozilla.org", "hkirschner@mozilla.com"]
     products:
       - "firefox"
       - "fennec"
       - "geckoview"
     record_in_processes: ["main"]
     description: User closes a tool in the devtools toolbox.