Bug 1119682 - TypeError: setting a property that has only a getter fix, r=felipe
authorSai Prathik <prathikcoding167@gmail.com>
Thu, 15 Jan 2015 11:58:00 +0000
changeset 224328 694b5bb3861f6d2bc55015e86b8c1dae4ad46b65
parent 224327 09b5d7e43b6011e92e483280eed4fba9617e0a25
child 224329 e73753a89c088079d69b02c2cbd5298d2028a8f3
push id54190
push userkwierso@gmail.com
push dateSat, 17 Jan 2015 02:06:29 +0000
treeherdermozilla-inbound@369a8f14ccf8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfelipe
bugs1119682
milestone38.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1119682 - TypeError: setting a property that has only a getter fix, r=felipe
toolkit/components/search/nsSearchSuggestions.js
--- a/toolkit/components/search/nsSearchSuggestions.js
+++ b/toolkit/components/search/nsSearchSuggestions.js
@@ -24,19 +24,20 @@ function SuggestAutoComplete() {
 SuggestAutoComplete.prototype = {
 
   _init: function() {
     this._suggestionController = new SearchSuggestionController(obj => this.onResultsReturned(obj));
     this._suggestionController.maxLocalResults = this._historyLimit;
   },
 
   get _suggestionLabel() {
-    delete this._suggestionLabel;
     let bundle = Services.strings.createBundle("chrome://global/locale/search/search.properties");
-    return this._suggestionLabel = bundle.GetStringFromName("suggestion_label");
+    let label = bundle.GetStringFromName("suggestion_label");
+    Object.defineProperty(SuggestAutoComplete.prototype, "_suggestionLabel", {value: label});
+    return label;
   },
 
   /**
    * The object implementing nsIAutoCompleteObserver that we notify when
    * we have found results
    * @private
    */
   _listener: null,