Bug 1133142 - downgrade 'mTempFile not equal to mTargetFile' from assertion to warning. r=yoric
authorJesse Ruderman <jruderman@gmail.com>
Thu, 05 Mar 2015 01:31:41 -0800
changeset 231973 659b843468a5a50be3f31eba00dd96bcfaf88d00
parent 231972 7c83615723964aff672d1b3894a849e4d8a1ebe9
child 231974 b2cf8cf45fd23f6da617ca1ba79f124b9d992ec9
push id56417
push userjruderman@mozilla.com
push dateThu, 05 Mar 2015 09:31:47 +0000
treeherdermozilla-inbound@659b843468a5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersyoric
bugs1133142
milestone39.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1133142 - downgrade 'mTempFile not equal to mTargetFile' from assertion to warning. r=yoric
netwerk/base/nsFileStreams.cpp
--- a/netwerk/base/nsFileStreams.cpp
+++ b/netwerk/base/nsFileStreams.cpp
@@ -959,17 +959,17 @@ nsAtomicFileOutputStream::Finish()
         if (!mTargetFileExists) {
             // If the target file did not exist when we were initialized, then the
             // temp file we gave out was actually a reference to the target file.
             // since we succeeded in writing to the temp file (and hence succeeded
             // in writing to the target file), there is nothing more to do.
 #ifdef DEBUG
             bool equal;
             if (NS_FAILED(mTargetFile->Equals(mTempFile, &equal)) || !equal)
-                NS_ERROR("mTempFile not equal to mTargetFile");
+                NS_WARNING("mTempFile not equal to mTargetFile");
 #endif
         }
         else {
             nsAutoString targetFilename;
             rv = mTargetFile->GetLeafName(targetFilename);
             if (NS_SUCCEEDED(rv)) {
                 // This will replace target.
                 rv = mTempFile->MoveTo(nullptr, targetFilename);