Bug 1501562 - Add crash checking for fennec wpt r=jgraham
☠☠ backed out by 3c1b4fc52fe2 ☠ ☠
authorWes Kocher <wkocher@mozilla.com>
Mon, 22 Apr 2019 09:15:18 +0000
changeset 470337 64c05e3826cdcc90e96c55e83015cf9c0bd67f3f
parent 470336 00f60c8cf8fbd9173079e8616251fe764bef3f1a
child 470338 fd7d4206ad5993616bd553ffaac2d1ddb90d9fce
push id112865
push usershindli@mozilla.com
push dateMon, 22 Apr 2019 15:52:44 +0000
treeherdermozilla-inbound@b4b482a09cf0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjgraham
bugs1501562
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1501562 - Add crash checking for fennec wpt r=jgraham Differential Revision: https://phabricator.services.mozilla.com/D28161
testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/fennec.py
--- a/testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/fennec.py
+++ b/testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/fennec.py
@@ -106,16 +106,17 @@ class FennecBrowser(FirefoxBrowser):
 
     def __init__(self, logger, prefs_root, test_type, package_name=None,
                  device_serial="emulator-5444", **kwargs):
         FirefoxBrowser.__init__(self, logger, None, prefs_root, test_type, **kwargs)
         self._package_name = package_name
         self.device_serial = device_serial
         self.tests_root = kwargs["tests_root"]
         self.install_fonts = kwargs["install_fonts"]
+        self.stackwalk_binary = kwargs["stackwalk_binary"]
 
     @property
     def package_name(self):
         """
         Name of app to run on emulator.
         """
         if self._package_name is None:
             self._package_name = "org.mozilla.fennec"
@@ -216,8 +217,13 @@ class FennecBrowser(FirefoxBrowser):
                     self.runner.device.device.remove_forwards(
                         "tcp:{}".format(self.marionette_port))
                 except Exception:
                     self.logger.warning("Failed to remove port forwarding")
             # We assume that stopping the runner prompts the
             # browser to shut down. This allows the leak log to be written
             self.runner.stop()
         self.logger.debug("stopped")
+
+    def check_crash(self, process, test):
+        if not os.environ.get("MINIDUMP_STACKWALK", "") and self.stackwalk_binary:
+            os.environ["MINIDUMP_STACKWALK"] = self.stackwalk_binary
+        return self.runner.check_for_crashes()