Bug 1465465 - Update blocked port names, r=annevk, r=valentin
authorAndrea Marchesini <amarchesini@mozilla.com>
Tue, 05 Jun 2018 07:49:02 +0200
changeset 421274 63652c45be83b318d6598b3835b825edc1fc29af
parent 421273 26fde37b83e925c44060e77dde8bd8c8474c4c78
child 421275 a358755643e92f8fc55a23e3ab1fbf88695b8bf3
push id104014
push useramarchesini@mozilla.com
push dateTue, 05 Jun 2018 06:00:59 +0000
treeherdermozilla-inbound@a358755643e9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersannevk, valentin
bugs1465465
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1465465 - Update blocked port names, r=annevk, r=valentin
netwerk/base/nsIOService.cpp
--- a/netwerk/base/nsIOService.cpp
+++ b/netwerk/base/nsIOService.cpp
@@ -99,17 +99,17 @@ int16_t gBadPortList[] = {
   7,    // echo
   9,    // discard
   11,   // systat
   13,   // daytime
   15,   // netstat
   17,   // qotd
   19,   // chargen
   20,   // ftp-data
-  21,   // ftp-cntl
+  21,   // ftp
   22,   // ssh
   23,   // telnet
   25,   // smtp
   37,   // time
   42,   // name
   43,   // nicname
   53,   // domain
   77,   // priv-rjs
@@ -122,49 +122,52 @@ int16_t gBadPortList[] = {
   104,  // acr-nema
   109,  // pop2
   110,  // pop3
   111,  // sunrpc
   113,  // auth
   115,  // sftp
   117,  // uucp-path
   119,  // nntp
-  123,  // NTP
+  123,  // ntp
   135,  // loc-srv / epmap
   139,  // netbios
   143,  // imap2
-  179,  // BGP
+  179,  // bgp
   389,  // ldap
-  465,  // smtp+ssl
+  //427,  // afp (alternate)
+  465,  // smtp (alternate)
   512,  // print / exec
   513,  // login
   514,  // shell
   515,  // printer
   526,  // tempo
   530,  // courier
-  531,  // Chat
+  531,  // chat
   532,  // netnews
   540,  // uucp
+  //548,  // afp
   556,  // remotefs
   563,  // nntp+ssl
-  587,  //
-  601,  //
+  587,  // smtp (outgoing)
+  601,  // syslog-conn
   636,  // ldap+ssl
   993,  // imap+ssl
   995,  // pop3+ssl
   2049, // nfs
-  3659,    // apple-sasl / PasswordServer
+  3659, // apple-sasl
   4045, // lockd
   6000, // x11
-  6665,    // Alternate IRC [Apple addition]
-  6666,    // Alternate IRC [Apple addition]
-  6667,    // Standard IRC [Apple addition]
-  6668,    // Alternate IRC [Apple addition]
-  6669,    // Alternate IRC [Apple addition]
-  0,    // This MUST be zero so that we can populating the array
+  6665, // irc (alternate)
+  6666, // irc (alternate)
+  6667, // irc (default)
+  6668, // irc (alternate)
+  6669, // irc (alternate)
+  //6697, // irc+tls
+  0,    // Sentinel value: This MUST be zero
 };
 
 static const char kProfileChangeNetTeardownTopic[] = "profile-change-net-teardown";
 static const char kProfileChangeNetRestoreTopic[] = "profile-change-net-restore";
 static const char kProfileDoChange[] = "profile-do-change";
 
 // Necko buffer defaults
 uint32_t   nsIOService::gDefaultSegmentSize = 4096;