Bug 1057387 - Remove incorrect documentation for the run/debug commands. r=gps
authorKartikaya Gupta <kgupta@mozilla.com>
Mon, 25 Aug 2014 19:39:55 -0400
changeset 201502 62e8be7789a3234cfdec04cf6507f3f9f0cf42be
parent 201501 8e9ed01b8a50c6b2b45a36b25d2d05103c82cb54
child 201503 dbd56f218adcfd06e71e5387970be610f2528e27
push id48188
push userkgupta@mozilla.com
push dateMon, 25 Aug 2014 23:40:14 +0000
treeherdermozilla-inbound@62e8be7789a3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgps
bugs1057387
milestone34.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1057387 - Remove incorrect documentation for the run/debug commands. r=gps
python/mozbuild/mozbuild/mach_commands.py
--- a/python/mozbuild/mozbuild/mach_commands.py
+++ b/python/mozbuild/mozbuild/mach_commands.py
@@ -758,24 +758,22 @@ class Install(MachCommandBase):
 
 @CommandProvider
 class RunProgram(MachCommandBase):
     """Launch the compiled binary"""
 
     @Command('run', category='post-build', allow_all_args=True,
         description='Run the compiled program.')
     @CommandArgument('params', default=None, nargs='...',
-        help='Command-line arguments to pass to the program.')
+        help='Command-line arguments to be passed through to the program. Not specifying a -profile or -P option will result in a temporary profile being used.')
     @CommandArgument('+remote', '+r', action='store_true',
         help='Do not pass the -no-remote argument by default.')
     @CommandArgument('+background', '+b', action='store_true',
         help='Do not pass the -foreground argument by default on Mac')
-    @CommandArgument('+profile', '+P', action='store_true',
-        help='Specify the profile to use')
-    def run(self, params, remote, background, profile):
+    def run(self, params, remote, background):
         try:
             args = [self.get_binary_path('app')]
         except Exception as e:
             print("It looks like your program isn't built.",
                 "You can run |mach build| to build it.")
             print(e)
             return 1
         if not remote:
@@ -795,35 +793,33 @@ class RunProgram(MachCommandBase):
 
 @CommandProvider
 class DebugProgram(MachCommandBase):
     """Debug the compiled binary"""
 
     @Command('debug', category='post-build', allow_all_args=True,
         description='Debug the compiled program.')
     @CommandArgument('params', default=None, nargs='...',
-        help='Command-line arguments to pass to the program.')
+        help='Command-line arguments to be passed through to the program. Not specifying a -profile or -P option will result in a temporary profile being used.')
     @CommandArgument('+remote', '+r', action='store_true',
         help='Do not pass the -no-remote argument by default')
     @CommandArgument('+background', '+b', action='store_true',
         help='Do not pass the -foreground argument by default on Mac')
     @CommandArgument('+debugger', default=None, type=str,
         help='Name of debugger to launch')
     @CommandArgument('+debugparams', default=None, metavar='params', type=str,
         help='Command-line arguments to pass to GDB or LLDB itself; split as the Bourne shell would.')
-    @CommandArgument('+profile', '+P', action='store_true',
-        help='Specifiy thr profile to use')
     # Bug 933807 introduced JS_DISABLE_SLOW_SCRIPT_SIGNALS to avoid clever
     # segfaults induced by the slow-script-detecting logic for Ion/Odin JITted
     # code.  If we don't pass this, the user will need to periodically type
     # "continue" to (safely) resume execution.  There are ways to implement
     # automatic resuming; see the bug.
     @CommandArgument('+slowscript', action='store_true',
         help='Do not set the JS_DISABLE_SLOW_SCRIPT_SIGNALS env variable; when not set, recoverable but misleading SIGSEGV instances may occur in Ion/Odin JIT code')
-    def debug(self, params, remote, background, profile, debugger, debugparams, slowscript):
+    def debug(self, params, remote, background, debugger, debugparams, slowscript):
         import which
         if debugger:
             try:
                 debugger = which.which(debugger)
             except Exception as e:
                 print("You don't have %s in your PATH" % (debugger))
                 print(e)
                 return 1