Bug 1452882 [wpt PR 10287] - [css-layout-api] Fix DCHECK with the custom layout and multicol., a=testonly
authorIan Kilpatrick <ikilpatrick@chromium.org>
Sun, 22 Apr 2018 08:43:23 +0000
changeset 415251 60aa0cb8748a94e49594d73ad68231f80994f012
parent 415250 3a62d29343d0e33cfd0cf83910150455e3b74018
child 415252 3964841447e51b34b81136bc83ee092230ae61a8
push id102533
push userwptsync@mozilla.com
push dateTue, 24 Apr 2018 12:30:46 +0000
treeherdermozilla-inbound@2342a0a0052f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1452882, 10287, 823074, 990780, 550148
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1452882 [wpt PR 10287] - [css-layout-api] Fix DCHECK with the custom layout and multicol., a=testonly Automatic update from web-platform-tests[css-layout-api] Fix DCHECK with the custom layout and multicol. There are probably larger changes that need to happen to ensure that the custom-layout and multicol play nicely together, but this removes a DCHECK crash for now. Bug: 823074 Change-Id: I98f4a34bd0c35e8cd3d23501ca64f38b96be9e7d Reviewed-on: https://chromium-review.googlesource.com/990780 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#550148} -- wpt-commits: 976e2c1f4b37821272f303aee639b62e1fd085f9 wpt-pr: 10287
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/css/css-layout-api/crash-multicol.https.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -315388,16 +315388,22 @@
     ]
    ],
    "css/css-layout-api/computed-style-layout-function.https.html": [
     [
      "/css/css-layout-api/computed-style-layout-function.https.html",
      {}
     ]
    ],
+   "css/css-layout-api/crash-multicol.https.html": [
+    [
+     "/css/css-layout-api/crash-multicol.https.html",
+     {}
+    ]
+   ],
    "css/css-layout-api/inline-style-layout-function.https.html": [
     [
      "/css/css-layout-api/inline-style-layout-function.https.html",
      {}
     ]
    ],
    "css/css-layout-api/supports.https.html": [
     [
@@ -505345,16 +505351,20 @@
   "css/css-layout-api/constraints-fixed-inline-size-percentage.https.html": [
    "c11a34aeba8f8743723b8859bb9c6fca886cda23",
    "reftest"
   ],
   "css/css-layout-api/constraints-fixed-inline-size-ref.html": [
    "1d7de325448b3132ec04b8788665829ff5d1fb02",
    "support"
   ],
+  "css/css-layout-api/crash-multicol.https.html": [
+   "efe476654107b6d01db2b75c2faeaa268d49efdc",
+   "testharness"
+  ],
   "css/css-layout-api/fallback-constructor-error.https.html": [
    "fdb9954e12f4628c114499a5e69f257b60377617",
    "reftest"
   ],
   "css/css-layout-api/fallback-layout-error.https.html": [
    "3d279f42a9b8e8ea0f6dc120d36ca0597372ef9b",
    "reftest"
   ],
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-layout-api/crash-multicol.https.html
@@ -0,0 +1,21 @@
+<!DOCTYPE html>
+<link rel="help" href="https://drafts.css-houdini.org/css-layout-api/">
+<meta name="assert" content="This test checks that browser doesn't crash when the layout() function is used with multicol." />
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<script src="/common/worklet-reftest.js"></script>
+
+<style>
+#test {
+  display: layout('test');
+  columns: 2;
+}
+</style>
+
+<div id="test"></div>
+
+<script>
+promise_test(async function() {
+  await importWorklet(CSS.layoutWorklet, {url: 'support/layout-position-child-worklet.js'});
+});
+</script>