author | Yoshi Huang <allstars.chh@mozilla.com> |
Tue, 03 May 2016 17:29:21 +0800 | |
changeset 295812 | 5ff6c23714396e0c4d8d1add6b3ec3e2815b9880 |
parent 295811 | b2dfb759f29036a6c211b36dd6246d3083d52f2a |
child 295813 | 4a3493053ffb01506babf159fd0b43e177be0f62 |
push id | 76099 |
push user | yhuang@mozilla.com |
push date | Tue, 03 May 2016 09:32:12 +0000 |
treeherder | mozilla-inbound@5ff6c2371439 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | francois |
bugs | 1077874 |
milestone | 49.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/modules/libpref/init/all.js +++ b/modules/libpref/init/all.js @@ -4994,35 +4994,35 @@ pref("browser.safebrowsing.downloads.rem pref("browser.safebrowsing.downloads.remote.url", "https://sb-ssl.google.com/safebrowsing/clientreport/download?key=%GOOGLE_API_KEY%"); pref("browser.safebrowsing.downloads.remote.block_dangerous", true); pref("browser.safebrowsing.downloads.remote.block_dangerous_host", true); pref("browser.safebrowsing.downloads.remote.block_potentially_unwanted", true); pref("browser.safebrowsing.downloads.remote.block_uncommon", true); pref("browser.safebrowsing.debug", false); pref("browser.safebrowsing.provider.google.lists", "goog-badbinurl-shavar,goog-downloadwhite-digest256,goog-phish-shavar,goog-malware-shavar,goog-unwanted-shavar"); -pref("browser.safebrowsing.provider.google.updateURL", "https://safebrowsing.google.com/safebrowsing/downloads?client=SAFEBROWSING_ID&appver=%VERSION%&pver=2.2&key=%GOOGLE_API_KEY%"); -pref("browser.safebrowsing.provider.google.gethashURL", "https://safebrowsing.google.com/safebrowsing/gethash?client=SAFEBROWSING_ID&appver=%VERSION%&pver=2.2"); +pref("browser.safebrowsing.provider.google.updateURL", "https://safebrowsing.google.com/safebrowsing/downloads?client=SAFEBROWSING_ID&appver=%MAJOR_VERSION%&pver=2.2&key=%GOOGLE_API_KEY%"); +pref("browser.safebrowsing.provider.google.gethashURL", "https://safebrowsing.google.com/safebrowsing/gethash?client=SAFEBROWSING_ID&appver=%MAJOR_VERSION%&pver=2.2"); pref("browser.safebrowsing.provider.google.reportURL", "https://safebrowsing.google.com/safebrowsing/diagnostic?client=%NAME%&hl=%LOCALE%&site="); pref("browser.safebrowsing.reportPhishMistakeURL", "https://%LOCALE%.phish-error.mozilla.com/?hl=%LOCALE%&url="); pref("browser.safebrowsing.reportPhishURL", "https://%LOCALE%.phish-report.mozilla.com/?hl=%LOCALE%&url="); pref("browser.safebrowsing.reportMalwareMistakeURL", "https://%LOCALE%.malware-error.mozilla.com/?hl=%LOCALE%&url="); // The table and global pref for blocking access to sites forbidden by policy pref("browser.safebrowsing.forbiddenURIs.enabled", false); pref("urlclassifier.forbiddenTable", "test-forbid-simple"); // The table and global pref for blocking plugin content pref("browser.safebrowsing.blockedURIs.enabled", false); pref("urlclassifier.blockedTable", "test-block-simple,mozplugin-block-digest256"); pref("browser.safebrowsing.provider.mozilla.lists", "mozstd-track-digest256,mozstd-trackwhite-digest256,mozfull-track-digest256,mozplugin-block-digest256,mozplugin2-block-digest256"); -pref("browser.safebrowsing.provider.mozilla.updateURL", "https://shavar.services.mozilla.com/downloads?client=SAFEBROWSING_ID&appver=%VERSION%&pver=2.2"); -pref("browser.safebrowsing.provider.mozilla.gethashURL", "https://shavar.services.mozilla.com/gethash?client=SAFEBROWSING_ID&appver=%VERSION%&pver=2.2"); +pref("browser.safebrowsing.provider.mozilla.updateURL", "https://shavar.services.mozilla.com/downloads?client=SAFEBROWSING_ID&appver=%MAJOR_VERSION%&pver=2.2"); +pref("browser.safebrowsing.provider.mozilla.gethashURL", "https://shavar.services.mozilla.com/gethash?client=SAFEBROWSING_ID&appver=%MAJOR_VERSION%&pver=2.2"); // Set to a date in the past to force immediate download in new profiles. pref("browser.safebrowsing.provider.mozilla.nextupdatetime", "1"); // Block lists for tracking protection. The name values will be used as the keys // to lookup the localized name in preferences.properties. pref("browser.safebrowsing.provider.mozilla.lists.mozstd.name", "mozstdName"); pref("browser.safebrowsing.provider.mozilla.lists.mozstd.description", "mozstdDesc"); pref("browser.safebrowsing.provider.mozilla.lists.mozfull.name", "mozfullName"); pref("browser.safebrowsing.provider.mozilla.lists.mozfull.description", "mozfullDesc");
new file mode 100644 --- /dev/null +++ b/toolkit/components/url-classifier/tests/unit/test_provider_url.js @@ -0,0 +1,34 @@ +Cu.import("resource://testing-common/AppInfo.jsm", this); +Cu.import("resource://gre/modules/Services.jsm"); + +function updateVersion(version) { + updateAppInfo({ version }); +} + +add_test(function test_provider_url() { + let urls = [ + "browser.safebrowsing.provider.google.updateURL", + "browser.safebrowsing.provider.google.gethashURL", + "browser.safebrowsing.provider.mozilla.updateURL", + "browser.safebrowsing.provider.mozilla.gethashURL" + ]; + + let versions = [ + "49.0", + "49.0.1", + "49.0a1", + "49.0b1", + "49.0esr", + "49.0.1esr" + ]; + + for (let version of versions) { + for (let url of urls) { + updateVersion(version); + let value = Services.urlFormatter.formatURLPref(url); + Assert.notEqual(value.indexOf("&appver=49.0&"), -1); + } + } + + run_next_test(); +});
--- a/toolkit/components/url-classifier/tests/unit/xpcshell.ini +++ b/toolkit/components/url-classifier/tests/unit/xpcshell.ini @@ -9,10 +9,11 @@ support-files = [test_addsub.js] [test_backoff.js] [test_dbservice.js] [test_hashcompleter.js] # Bug 752243: Profile cleanup frequently fails #skip-if = os == "mac" || os == "linux" [test_partial.js] [test_prefixset.js] +[test_provider_url.js] [test_streamupdater.js] [test_digest256.js]
--- a/toolkit/components/urlformatter/nsURLFormatter.js +++ b/toolkit/components/urlformatter/nsURLFormatter.js @@ -99,16 +99,17 @@ nsURLFormatterService.prototype = { } catch(e) { return "ZZ"; } }, VENDOR: function() { return this.appInfo.vendor; }, NAME: function() { return this.appInfo.name; }, ID: function() { return this.appInfo.ID; }, VERSION: function() { return this.appInfo.version; }, + MAJOR_VERSION: function() { return this.appInfo.version.replace(/^([^\.]+\.[0-9]+[a-z]*).*/gi, "$1"); }, APPBUILDID: function() { return this.appInfo.appBuildID; }, PLATFORMVERSION: function() { return this.appInfo.platformVersion; }, PLATFORMBUILDID: function() { return this.appInfo.platformBuildID; }, APP: function() { return this.appInfo.name.toLowerCase().replace(/ /, ""); }, OS: function() { return this.appInfo.OS; }, XPCOMABI: function() { return this.ABI; }, BUILD_TARGET: function() { return this.appInfo.OS + "_" + this.ABI; }, OS_VERSION: function() { return this.OSVersion; },