Bug 1491561 follow-up: Add back Cu.createCommandParams() which was accidentally removed
authorEhsan Akhgari <ehsan@mozilla.com>
Tue, 18 Sep 2018 10:47:04 -0400
changeset 437040 5fb38b2b939c
parent 437039 3655d882ad9c
child 437041 4fc9fae13df7
push id107972
push usereakhgari@mozilla.com
push dateTue, 18 Sep 2018 15:15:52 +0000
treeherdermozilla-inbound@5fb38b2b939c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1491561
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1491561 follow-up: Add back Cu.createCommandParams() which was accidentally removed
js/xpconnect/idl/xpccomponents.idl
js/xpconnect/src/XPCComponents.cpp
--- a/js/xpconnect/idl/xpccomponents.idl
+++ b/js/xpconnect/idl/xpccomponents.idl
@@ -722,16 +722,19 @@ interface nsIXPCComponents_Utils : nsISu
     void recordReplayDirective(in long directive);
 
     /* Create a spellchecker object. */
     nsIEditorSpellCheck createSpellChecker();
 
     /* Create a commandline object. */
     nsISupports createCommandLine();
 
+    /* Create a command params object. */
+    nsICommandParams createCommandParams();
+
     /* Create a loadcontext object. */
     nsILoadContext createLoadContext();
 
     /* Create a private loadcontext object. */
     nsILoadContext createPrivateLoadContext();
 
     /* Create a persistent property object. */
     nsIPersistentProperties createPersistentProperties();
--- a/js/xpconnect/src/XPCComponents.cpp
+++ b/js/xpconnect/src/XPCComponents.cpp
@@ -3229,16 +3229,25 @@ nsXPCComponents_Utils::CreateCommandLine
 {
     NS_ENSURE_ARG_POINTER(aCommandLine);
     nsCOMPtr<nsISupports> commandLine = new nsCommandLine();
     commandLine.forget(aCommandLine);
     return NS_OK;
 }
 
 NS_IMETHODIMP
+nsXPCComponents_Utils::CreateCommandParams(nsICommandParams** aCommandParams)
+{
+    NS_ENSURE_ARG_POINTER(aCommandParams);
+    nsCOMPtr<nsICommandParams> commandParams = new nsCommandParams();
+    commandParams.forget(aCommandParams);
+    return NS_OK;
+}
+
+NS_IMETHODIMP
 nsXPCComponents_Utils::CreateLoadContext(nsILoadContext** aLoadContext)
 {
     NS_ENSURE_ARG_POINTER(aLoadContext);
     nsCOMPtr<nsILoadContext> loadContext = ::CreateLoadContext();
     loadContext.forget(aLoadContext);
     return NS_OK;
 }