Bug 825866. Part 6: Annotate nsIWidgetListener method implementations to indicate that they're virtual and must override. r=tnikkel
authorRobert O'Callahan <robert@ocallahan.org>
Fri, 04 Jan 2013 02:23:10 +1300
changeset 117496 5f2b030f0b743f65fefabef1337b462a2981a7df
parent 117495 dcb03b79fd15da8794af0821dad0d0e861f6663d
child 117497 fbcf7d62c9888a71f34e83dcdc0b6597ae0bc2fc
push id20537
push userrocallahan@mozilla.com
push dateThu, 03 Jan 2013 21:31:05 +0000
treeherdermozilla-inbound@042de8e1b27c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstnikkel
bugs825866
milestone20.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 825866. Part 6: Annotate nsIWidgetListener method implementations to indicate that they're virtual and must override. r=tnikkel
view/public/nsIView.h
--- a/view/public/nsIView.h
+++ b/view/public/nsIView.h
@@ -431,26 +431,26 @@ public:
 
   // Update the cached RootViewManager for all view manager descendents,
   // If the hierarchy is being removed, aViewManagerParent points to the view
   // manager for the hierarchy's old parent, and will have its mouse grab
   // released if it points to any view in this view hierarchy.
   void InvalidateHierarchy(nsViewManager *aViewManagerParent);
 
   // nsIWidgetListener
-  virtual nsIPresShell* GetPresShell();
-  virtual nsIView* GetView() { return this; }
-  bool WindowMoved(nsIWidget* aWidget, int32_t x, int32_t y);
-  bool WindowResized(nsIWidget* aWidget, int32_t aWidth, int32_t aHeight);
-  bool RequestWindowClose(nsIWidget* aWidget);
-  void WillPaintWindow(nsIWidget* aWidget, bool aWillSendDidPaint);
-  bool PaintWindow(nsIWidget* aWidget, nsIntRegion aRegion, uint32_t aFlags);
-  void DidPaintWindow();
-  void RequestRepaint() MOZ_OVERRIDE;
-  nsEventStatus HandleEvent(nsGUIEvent* aEvent, bool aUseAttachedEvents);
+  virtual nsIPresShell* GetPresShell() MOZ_OVERRIDE;
+  virtual nsIView* GetView() MOZ_OVERRIDE { return this; }
+  virtual bool WindowMoved(nsIWidget* aWidget, int32_t x, int32_t y) MOZ_OVERRIDE;
+  virtual bool WindowResized(nsIWidget* aWidget, int32_t aWidth, int32_t aHeight) MOZ_OVERRIDE;
+  virtual bool RequestWindowClose(nsIWidget* aWidget) MOZ_OVERRIDE;
+  virtual void WillPaintWindow(nsIWidget* aWidget, bool aWillSendDidPaint) MOZ_OVERRIDE;
+  virtual bool PaintWindow(nsIWidget* aWidget, nsIntRegion aRegion, uint32_t aFlags) MOZ_OVERRIDE;
+  virtual void DidPaintWindow() MOZ_OVERRIDE;
+  virtual void RequestRepaint() MOZ_OVERRIDE;
+  virtual nsEventStatus HandleEvent(nsGUIEvent* aEvent, bool aUseAttachedEvents) MOZ_OVERRIDE;
 
   virtual ~nsIView();
 
   nsPoint GetOffsetTo(const nsIView* aOther, const int32_t aAPD) const;
   nsIWidget* GetNearestWidget(nsPoint* aOffset, const int32_t aAPD) const;
 
 protected:
   // Do the actual work of ResetWidgetBounds, unconditionally.  Don't