Bug 1334831 - Make the printpreview_bug396024_helper.xul test not depend on the removeChild return value, r=jaws.
authorFlorian Quèze <florian@queze.net>
Mon, 30 Jan 2017 08:10:15 +0100
changeset 331623 5d95649edd01cee9bf502db4a7b07de0f965f49f
parent 331622 c79f0867b4ece170ec6a2a1832839d22278c45b2
child 331624 cbe16a8a26150a0469177a50e08f090146d2afbe
push id86308
push userflorian@queze.net
push dateMon, 30 Jan 2017 07:14:53 +0000
treeherdermozilla-inbound@a9d172aa4414 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws
bugs1334831
milestone54.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1334831 - Make the printpreview_bug396024_helper.xul test not depend on the removeChild return value, r=jaws.
layout/base/tests/chrome/printpreview_bug396024_helper.xul
--- a/layout/base/tests/chrome/printpreview_bug396024_helper.xul
+++ b/layout/base/tests/chrome/printpreview_bug396024_helper.xul
@@ -95,24 +95,24 @@ function run3() {
              .getInterface(Components.interfaces.nsIWebBrowserPrint);
   ok(gWbp.doingPrintPreview, "Should be doing print preview");
   exitprintpreview();
   setTimeout(run4, 0);
 }
 
 function run4() {
   var i = document.getElementById("i");
-  var x = i.parentNode.removeChild(i);
+  i.parentNode.removeChild(i);
   var loadhandler = function() {
     document.getElementById("i").removeEventListener("load", loadhandler, true);
     setTimeout(run5, 0);
   };
-  x.addEventListener("load", loadhandler, true);
+  i.addEventListener("load", loadhandler, true);
   document.documentElement.getBoundingClientRect();
-  document.documentElement.appendChild(x);
+  document.documentElement.appendChild(i);
   gWbp = window.frames[1].QueryInterface(Components.interfaces.nsIInterfaceRequestor)
              .getInterface(Components.interfaces.nsIWebBrowserPrint);
   ok(!gWbp.doingPrintPreview, "Should not be doing print preview anymore2");
 }
 
 function run5() {
   //XXX this shouldn't be necessary, see bug 405555
   printpreview();