Bug 1480885 [wpt PR 12302] - Rename VRDisplayHost to XRDeviceImpl, a=testonly
authorAnna Offenwanger <offenwanger@chromium.org>
Mon, 06 Aug 2018 17:17:39 +0000
changeset 430587 5d8a1fb0df93012594d1c25fbcbecb7dba3953b7
parent 430586 4fd10daf5327b544da89d1625290323223701850
child 430588 97b470c2dc674de42a7996a8357d129f86488066
push id106198
push userwptsync@mozilla.com
push dateWed, 08 Aug 2018 12:12:14 +0000
treeherdermozilla-inbound@caf4088ab8c8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1480885, 12302, 842025, 1162693, 580697
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1480885 [wpt PR 12302] - Rename VRDisplayHost to XRDeviceImpl, a=testonly Automatic update from web-platform-testsRename VRDisplayHost to XRDeviceImpl VRDisplayHost serves as the browser side implementation of the XRDevice mojo interface, so renaming it to make that explicit. Bug: 842025 Cq-Include-Trybots: luci.chromium.try​:android_optional_gpu_tests_rel;luci.chromium.try​:linux_optional_gpu_tests_rel;luci.chromium.try​:linux_vr;luci.chromium.try​:mac_optional_gpu_tests_rel;luci.chromium.try​:win_optional_gpu_tests_rel Change-Id: I24fc584f06cfcc50c942e2df8bc451badb67e20f Reviewed-on: https://chromium-review.googlesource.com/1162693 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#580697} -- wpt-commits: f4e5090a404df6782535851740b4b58e68b7ab5b wpt-pr: 12302
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/resources/chromium/webxr-test.js
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -622953,17 +622953,17 @@
    "630a7da945c225b1026e677c30888b0e11df9be2",
    "support"
   ],
   "resources/chromium/webusb-test.js.headers": [
    "6805c323df5a975231648b830e33ce183c3cbbd3",
    "support"
   ],
   "resources/chromium/webxr-test.js": [
-   "7ed9332bd6ee6b861aaefc9c3f4efe5d636d6e3d",
+   "d760e7c76d3050973e365021766cb00488b16156",
    "support"
   ],
   "resources/chromium/webxr-test.js.headers": [
    "6805c323df5a975231648b830e33ce183c3cbbd3",
    "support"
   ],
   "resources/idlharness.js": [
    "d1dbd29c2d82b0a13527ccb36f49ef4902d8c758",
--- a/testing/web-platform/tests/resources/chromium/webxr-test.js
+++ b/testing/web-platform/tests/resources/chromium/webxr-test.js
@@ -56,17 +56,17 @@ class MockVRService {
     for (let i = 0; i < this.devices_.length; i++) {
       this.devices_[i].notifyClientOfDisplay();
     }
 
     return Promise.resolve();
   }
 }
 
-// Implements both VRDisplayHost and VRMagicWindowProvider. Maintains a mock for
+// Implements both XRDeviceImpl and VRMagicWindowProvider. Maintains a mock for
 // XRPresentationProvider.
 class MockDevice {
   constructor(fakeDeviceInit, service) {
     this.displayClient_ = new device.mojom.VRDisplayClientPtr();
     this.presentation_provider_ = new MockXRPresentationProvider();
 
     this.pose_ = null;
     this.next_frame_id_ = 0;
@@ -84,24 +84,24 @@ class MockDevice {
     if (service.client_) {
       this.notifyClientOfDisplay();
     }
   }
 
   // Functions for setup.
   // This function calls to the backend to add this device to the list.
   notifyClientOfDisplay() {
-    let displayPtr = new device.mojom.VRDisplayHostPtr();
-    let displayRequest = mojo.makeRequest(displayPtr);
-    let displayBinding =
-        new mojo.Binding(device.mojom.VRDisplayHost, this, displayRequest);
+    let devicePtr = new device.mojom.XRDevicePtr();
+    let deviceRequest = mojo.makeRequest(devicePtr);
+    let deviceBinding =
+        new mojo.Binding(device.mojom.XRDevice, this, deviceRequest);
 
     let clientRequest = mojo.makeRequest(this.displayClient_);
     this.service_.client_.onDisplayConnected(
-        displayPtr, clientRequest, this.displayInfo_);
+        devicePtr, clientRequest, this.displayInfo_);
   }
 
   // Test methods.
   setXRPresentationFrameData(poseMatrix, views) {
     if (poseMatrix == null) {
       this.pose_ = null;
     } else {
       this.setPoseFromMatrix(poseMatrix);
@@ -274,17 +274,17 @@ class MockDevice {
     });
   }
 
   updateSessionGeometry(frame_size, display_rotation) {
     // This function must exist to ensure that calls to it do not crash, but we
     // do not have any use for this data at present.
   }
 
-  // VRDisplayHost implementation.
+  // XRDeviceImpl implementation.
 
   requestSession(sessionOptions, was_activation) {
     return this.supportsSession(sessionOptions).then((result) => {
       // The JavaScript bindings convert c_style_names to camelCase names.
       let options = new device.mojom.XRPresentationTransportOptions();
       options.transportMethod =
           device.mojom.XRPresentationTransportMethod.SUBMIT_AS_MAILBOX_HOLDER;
       options.waitForTransferNotification = true;