Bug 1381584 - Remove unused cite field from nsIDOMHTMLQuoteElement. r=bz
authorAndrew McCreight <continuation@gmail.com>
Mon, 17 Jul 2017 12:36:41 -0700
changeset 369354 5a3f91efbc00f0d71773abadb276a8415da6592e
parent 369353 5c928291e2d5051284d8858486d054b4c524bd18
child 369355 f60882bf32bc58321a7d14859ccdb5f1f3a34bc9
push id92694
push userryanvm@gmail.com
push dateTue, 18 Jul 2017 17:00:23 +0000
treeherdermozilla-inbound@e95d76dbe651 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbz
bugs1381584
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1381584 - Remove unused cite field from nsIDOMHTMLQuoteElement. r=bz MozReview-Commit-ID: 2sKSRcl6B1W
dom/html/HTMLSharedElement.cpp
dom/html/HTMLSharedElement.h
dom/interfaces/html/nsIDOMHTMLQuoteElement.idl
--- a/dom/html/HTMLSharedElement.cpp
+++ b/dom/html/HTMLSharedElement.cpp
@@ -43,17 +43,17 @@ NS_INTERFACE_MAP_BEGIN(HTMLSharedElement
   NS_INTERFACE_MAP_ENTRY_IF_TAG(nsIDOMHTMLHeadElement, head)
   NS_INTERFACE_MAP_ENTRY_IF_TAG(nsIDOMHTMLHtmlElement, html)
 NS_INTERFACE_MAP_END_INHERITING(nsGenericHTMLElement)
 
 
 NS_IMPL_ELEMENT_CLONE(HTMLSharedElement)
 
 // nsIDOMHTMLQuoteElement
-NS_IMPL_URI_ATTR(HTMLSharedElement, Cite, cite)
+// Empty
 
 // nsIDOMHTMLHeadElement
 // Empty
 
 // nsIDOMHTMLHtmlElement
 NS_IMPL_STRING_ATTR(HTMLSharedElement, Version, version)
 
 // nsIDOMHTMLBaseElement
--- a/dom/html/HTMLSharedElement.h
+++ b/dom/html/HTMLSharedElement.h
@@ -142,17 +142,21 @@ public:
   }
   void SetCompact(bool aCompact, ErrorResult& aResult)
   {
     MOZ_ASSERT(mNodeInfo->Equals(nsGkAtoms::dir));
     SetHTMLBoolAttr(nsGkAtoms::compact, aCompact, aResult);
   }
 
   // HTMLQuoteElement
-  // The XPCOM GetCite works fine for us
+  void GetCite(nsString& aCite)
+  {
+    GetHTMLURIAttr(nsGkAtoms::cite, aCite);
+  }
+
   void SetCite(const nsAString& aValue, ErrorResult& aResult)
   {
     MOZ_ASSERT(mNodeInfo->Equals(nsGkAtoms::q) ||
                mNodeInfo->Equals(nsGkAtoms::blockquote));
     SetHTMLAttr(nsGkAtoms::cite, aValue, aResult);
   }
 
   // HTMLHtmlElement
--- a/dom/interfaces/html/nsIDOMHTMLQuoteElement.idl
+++ b/dom/interfaces/html/nsIDOMHTMLQuoteElement.idl
@@ -1,23 +1,11 @@
 /* -*- Mode: IDL; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-#include "nsIDOMHTMLElement.idl"
-
-/**
- * The nsIDOMHTMLQuoteElement interface is the interface to a [X]HTML
- * q element.
- *
- * This interface is trying to follow the DOM Level 2 HTML specification:
- * http://www.w3.org/TR/DOM-Level-2-HTML/
- *
- * with changes from the work-in-progress WHATWG HTML specification:
- * http://www.whatwg.org/specs/web-apps/current-work/
- */
+#include "nsISupports.idl"
 
 [uuid(f02502b5-32a6-4df7-8a57-1416553a3188)]
 interface nsIDOMHTMLQuoteElement : nsISupports
 {
-           attribute DOMString        cite;
 };