Bug 1507455 - Update tab order in Inspector sidebar. r=gl
authorRazvan Caliman <rcaliman@mozilla.com>
Mon, 14 Jan 2019 09:57:06 +0000
changeset 453721 5a2081993bcb0ec1b26531a4a9c6bc9e7bb82e0b
parent 453720 29b9eaabfca3c750633854959c339c8c64e9b087
child 453722 6a2a0437e8e976cc69f6120745b90d9fe4797789
push id111141
push userncsoregi@mozilla.com
push dateMon, 14 Jan 2019 17:26:52 +0000
treeherdermozilla-inbound@b8baa741549c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgl
bugs1507455
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1507455 - Update tab order in Inspector sidebar. r=gl Differential Revision: https://phabricator.services.mozilla.com/D16304
devtools/client/inspector/extensions/test/browser_inspector_extension_sidebar.js
devtools/client/inspector/inspector.js
--- a/devtools/client/inspector/extensions/test/browser_inspector_extension_sidebar.js
+++ b/devtools/client/inspector/extensions/test/browser_inspector_extension_sidebar.js
@@ -256,18 +256,16 @@ add_task(async function teardownExtensio
   ok(!inspector.sidebar.getTabPanel(SIDEBAR_ID),
      "The rendered extension sidebar has been removed");
 
   const inspectorStoreState = inspector.store.getState();
 
   Assert.deepEqual(inspectorStoreState.extensionsSidebar, {},
                    "The extensions sidebar Redux store data has been cleared");
 
-  await toolbox.destroy();
-
   await extension.unload();
 
   toolbox = null;
   inspector = null;
   extension = null;
 });
 
 add_task(async function testActiveTabOnNonExistingSidebar() {
--- a/devtools/client/inspector/inspector.js
+++ b/devtools/client/inspector/inspector.js
@@ -906,28 +906,28 @@ Inspector.prototype = {
         id: "layoutview",
         title: INSPECTOR_L10N.getStr("inspector.sidebar.layoutViewTitle2"),
       },
       {
         id: "computedview",
         title: INSPECTOR_L10N.getStr("inspector.sidebar.computedViewTitle"),
       },
       {
+        id: "fontinspector",
+        title: INSPECTOR_L10N.getStr("inspector.sidebar.fontInspectorTitle"),
+      },
+      {
         id: "animationinspector",
         title: INSPECTOR_L10N.getStr("inspector.sidebar.animationInspectorTitle"),
       },
-      {
-        id: "fontinspector",
-        title: INSPECTOR_L10N.getStr("inspector.sidebar.fontInspectorTitle"),
-      },
     ];
 
     if (this._supportsChangesPanel()) {
       // Insert Changes as third tab, right after Computed.
-      // TODO: move this inline to `sidebarPanels` above when addressing Bug 1491887.
+      // TODO: move this inline to `sidebarPanels` above when addressing Bug 1511877.
       sidebarPanels.splice(2, 0, {
         id: "changesview",
         title: INSPECTOR_L10N.getStr("inspector.sidebar.changesViewTitle"),
       });
     }
 
     if (Services.prefs.getBoolPref("devtools.inspector.new-rulesview.enabled")) {
       sidebarPanels.push({