Bug 1337536 - MessageType ctor assert should check cdtype. r=billm
authorAndrew McCreight <continuation@gmail.com>
Tue, 07 Feb 2017 14:15:31 -0800
changeset 342301 59c0ce731318d210b56b349f1762cf6aeba5c686
parent 342300 5df20eaa8ef4c3eff723c1d597a439e141395881
child 342302 6e0ab51985e41c41aa476bb01505cb0774468ce0
push id86826
push userkwierso@gmail.com
push dateFri, 10 Feb 2017 23:33:17 +0000
treeherdermozilla-inbound@2c7816419218 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbillm
bugs1337536
milestone54.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1337536 - MessageType ctor assert should check cdtype. r=billm type is some existing Python object, so this assertion can never fail. Looking at GatherDecls::visitMessageDecl, I think this is supposed to be checking cdecl. MozReview-Commit-ID: 8Oppw5SYdWO
ipc/ipdl/ipdl/type.py
--- a/ipc/ipdl/ipdl/type.py
+++ b/ipc/ipdl/ipdl/type.py
@@ -180,17 +180,17 @@ class IPDLType(Type):
     def needsMoreJuiceThan(self, o):
         return not IPDLType.convertsTo(self, o)
 
 class MessageType(IPDLType):
     def __init__(self, nested, prio, sendSemantics, direction,
                  ctor=False, dtor=False, cdtype=None, compress=False,
                  verify=False):
         assert not (ctor and dtor)
-        assert not (ctor or dtor) or type is not None
+        assert not (ctor or dtor) or cdtype is not None
 
         self.nested = nested
         self.prio = prio
         self.nestedRange = (nested, nested)
         self.sendSemantics = sendSemantics
         self.direction = direction
         self.params = [ ]
         self.returns = [ ]