Bug 1545707 - Dispatch cancel events for transitions/animations canceled on ::marker pseudo elements when the become no longer rendered; r=mats
authorBrian Birtles <birtles@gmail.com>
Mon, 22 Apr 2019 00:54:29 +0000
changeset 470327 593761a810cea50aebb2b9a423af791c773c10ac
parent 470326 bc8f94bb6bb6dad3f71b1ac955f1d89643548013
child 470328 76a363f06ebd40d418d483b41b12721ab728f38c
push id112863
push usershindli@mozilla.com
push dateMon, 22 Apr 2019 09:53:25 +0000
treeherdermozilla-inbound@ab1da7fa2ad0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmats
bugs1545707
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1545707 - Dispatch cancel events for transitions/animations canceled on ::marker pseudo elements when the become no longer rendered; r=mats Differential Revision: https://phabricator.services.mozilla.com/D28176
layout/base/RestyleManager.cpp
testing/web-platform/meta/css/css-transitions/non-rendered-element-002.html.ini
--- a/layout/base/RestyleManager.cpp
+++ b/layout/base/RestyleManager.cpp
@@ -1979,17 +1979,17 @@ RestyleManager::AnimationsWithDestroyedF
   mRestyleManager->mAnimationsWithDestroyedFrame = this;
 }
 
 void RestyleManager::AnimationsWithDestroyedFrame ::
     StopAnimationsForElementsWithoutFrames() {
   StopAnimationsWithoutFrame(mContents, PseudoStyleType::NotPseudo);
   StopAnimationsWithoutFrame(mBeforeContents, PseudoStyleType::before);
   StopAnimationsWithoutFrame(mAfterContents, PseudoStyleType::after);
-  StopAnimationsWithoutFrame(mAfterContents, PseudoStyleType::marker);
+  StopAnimationsWithoutFrame(mMarkerContents, PseudoStyleType::marker);
 }
 
 void RestyleManager::AnimationsWithDestroyedFrame ::StopAnimationsWithoutFrame(
     nsTArray<RefPtr<nsIContent>>& aArray, PseudoStyleType aPseudoType) {
   nsAnimationManager* animationManager =
       mRestyleManager->PresContext()->AnimationManager();
   nsTransitionManager* transitionManager =
       mRestyleManager->PresContext()->TransitionManager();
deleted file mode 100644
--- a/testing/web-platform/meta/css/css-transitions/non-rendered-element-002.html.ini
+++ /dev/null
@@ -1,4 +0,0 @@
-[non-rendered-element-002.html]
-  expected: TIMEOUT
-  [Transitions on ::marker pseudo-elements are canceled when the parent display type is no longer list-item]
-    expected: TIMEOUT