Bug 1523684: Set `--target` to be a 32 bit target for L10n builds on win32; r=nalexander,Callek a=tomprince
authorTom Prince <mozilla@hocat.ca>
Tue, 29 Jan 2019 12:38:31 -0700
changeset 456016 58b77413fd917d29a8975f87903309056e8affe4
parent 455982 4440fbf71c72e13cfcb6257bbae6024052ffd46d
child 456017 9e919be867b30a5343a5963bca248efe097d42d5
push id111567
push usershindli@mozilla.com
push dateWed, 30 Jan 2019 04:17:24 +0000
treeherdermozilla-inbound@0c6d81e2d4fa [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnalexander, Callek, tomprince
bugs1523684, 1522354
milestone67.0a1
first release with
nightly linux32
58b77413fd91 / 67.0a1 / 20190130001444 / files
nightly linux64
58b77413fd91 / 67.0a1 / 20190130001444 / files
nightly mac
58b77413fd91 / 67.0a1 / 20190130001444 / files
nightly win32
58b77413fd91 / 67.0a1 / 20190130001444 / files
nightly win64
58b77413fd91 / 67.0a1 / 20190130001444 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1523684: Set `--target` to be a 32 bit target for L10n builds on win32; r=nalexander,Callek a=tomprince In Bug 1522354, the default for `--host` was changed to detect running on a 64bit host. Since `--target` defaults to `--host`, this changed the default for `--target` as well. This didn't affect builds, as they explictly set the `--target` in `build/win32/mozconfig.vs2017`. Set it explicitly in L10n builds as well. Differential Revision: https://phabricator.services.mozilla.com/D17967
browser/config/mozconfigs/win32/l10n-mozconfig
--- a/browser/config/mozconfigs/win32/l10n-mozconfig
+++ b/browser/config/mozconfigs/win32/l10n-mozconfig
@@ -1,11 +1,13 @@
 . "$topsrcdir/browser/config/mozconfigs/common"
 . "$topsrcdir/build/mozconfig.no-compile"
 
+ac_add_options --target=i686-pc-mingw32
+
 ac_add_options --enable-update-channel=${MOZ_UPDATE_CHANNEL}
 ac_add_options --with-l10n-base=../../l10n
 ac_add_options --with-branding=browser/branding/nightly
 
 ac_add_options --disable-nodejs
 unset NODEJS
 
 export MOZILLA_OFFICIAL=1