Bug 1168179 - Mark nsPresContext::mMedium as MOZ_UNSAFE_REF. r=dbaron
authorMichael Layzell <michael@thelayzells.com>
Tue, 16 Jun 2015 08:17:00 -0400
changeset 249155 57f67506a3541717bf7cf382e100e09bca89d494
parent 249154 f5d9db72645de852ff60ebe7d12f9e5f522bf7d4
child 249156 a1558d74b4db051c079d1cf3414effae2ef8160b
push id61153
push userryanvm@gmail.com
push dateTue, 16 Jun 2015 19:06:09 +0000
treeherdermozilla-inbound@e8b8cdc974ab [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdbaron
bugs1168179
milestone41.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1168179 - Mark nsPresContext::mMedium as MOZ_UNSAFE_REF. r=dbaron
layout/base/nsPresContext.h
--- a/layout/base/nsPresContext.h
+++ b/layout/base/nsPresContext.h
@@ -1225,18 +1225,17 @@ protected:
                                             // since there is no dependency
                                             // from gfx back to layout.
   nsRefPtr<mozilla::EventStateManager> mEventManager;
   nsRefPtr<nsRefreshDriver> mRefreshDriver;
   nsRefPtr<nsTransitionManager> mTransitionManager;
   nsRefPtr<nsAnimationManager> mAnimationManager;
   nsRefPtr<mozilla::RestyleManager> mRestyleManager;
   nsRefPtr<mozilla::CounterStyleManager> mCounterStyleManager;
-  nsIAtom*              mMedium;        // initialized by subclass ctors;
-                                        // weak pointer to static atom
+  nsIAtom* MOZ_UNSAFE_REF("always a static atom") mMedium; // initialized by subclass ctors
   nsCOMPtr<nsIAtom> mMediaEmulated;
 
   nsILinkHandler*       mLinkHandler;   // [WEAK]
 
   // Formerly mLangGroup; moving from charset-oriented langGroup to
   // maintaining actual language settings everywhere (see bug 524107).
   // This may in fact hold a langGroup such as x-western rather than
   // a specific language, however (e.g, if it is inferred from the