Bug 1594520 - Fix argument lists in .vscode/tasks.json r=jya
authorTed Campbell <tcampbell@mozilla.com>
Wed, 13 Nov 2019 01:06:07 +0000
changeset 501687 57a4794a87f25c62f04126350416dc498ac03584
parent 501686 530c4ab772a674e636b56cd5147a0773009cf9a3
child 501688 27ab68adb7d07cf04405396a8fd8b97fe0b67d1b
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjya
bugs1594520
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1594520 - Fix argument lists in .vscode/tasks.json r=jya In the migration to the 2.0 format we seem to have dropped the base mach command from a few of the defined tasks. Depends on D52081 Differential Revision: https://phabricator.services.mozilla.com/D52082
.vscode/tasks.json
--- a/.vscode/tasks.json
+++ b/.vscode/tasks.json
@@ -3,45 +3,51 @@
     // for the documentation about the tasks.json format
     "version": "2.0.0",
     "type": "shell",
     "command": "${workspaceRoot}/mach",
     "windows": {
       "command": "\"\\mozilla-build\\start-shell.bat mach\""
     },
     "args": ["--log-no-times"],
-    "echoCommand": true,
     "tasks": [
       {
+        "label": "clobber",
+        "args": ["clobber"],
+        "problemMatcher": []
+      },
+      {
         "label": "clobber-python",
         "args": ["clobber", "python"],
         "problemMatcher": []
       },
       {
         "label": "configure",
+        "args": ["configure"],
         "problemMatcher": []
       },
       {
         "label": "build",
+        "args": ["build"],
         "problemMatcher": {
           "owner": "cpp",
           "fileLocation": "absolute",
           "pattern": {
             "regexp": "^.*?([^\\s]*)[:(](\\d+)[:,](\\d+)[)]?:\\s+(warning|error):\\s+(.*)$",
             "file": 1,
             "line": 2,
             "column": 3,
             "severity": 4,
             "message": 5
           }
         }
       },
       {
         "label": "build-binaries",
-        "args": ["--log-no-times", "build", "binaries"],
+        "args": ["build", "binaries"],
         "problemMatcher": {
           "owner": "cpp",
           "fileLocation": "absolute",
           "pattern": {
             "regexp": "^(.*)[:(](\\d+)[:,](\\d+)[)]?:\\s+(warning|error):\\s+(.*)$",
             "file": 1,
             "line": 2,
             "column": 3,
@@ -51,95 +57,96 @@
         },
         "group": {
             "kind": "build",
             "isDefault": true
         }
       },
       {
         "label": "build-faster",
-        "args": ["--log-no-times", "build", "faster"],
+        "args": ["build", "faster"],
         "problemMatcher": {
           "owner": "cpp",
           "fileLocation": "absolute",
           "pattern": {
             "regexp": "^(.*)[:(](\\d+)[:,](\\d+)[)]?:\\s+(warning|error):\\s+(.*)$",
             "file": 1,
             "line": 2,
             "column": 3,
             "severity": 4,
             "message": 5
           }
         }
       },
       {
         "label": "run",
-        "args": ["-purgecaches"],
+        "args": ["run", "-purgecaches"],
         "problemMatcher": []
       },
       {
         "label": "lint-wo",
         "args": ["lint", "-wo"],
         "problemMatcher": ["$eslint-stylish"]
       },
       {
         "label": "eslint",
+        "args": ["eslint", "${file}"],
         "problemMatcher": ["$eslint-stylish"]
       },
       {
         "label": "eslint-fix",
         "args": ["eslint", "--fix", "${file}"],
         "problemMatcher": ["$eslint-stylish"]
       },
       {
         "label": "test",
-        "args": ["${relativeFile}"],
+        "args": ["test", "${relativeFile}"],
         "group":"test",
         "presentation": {
             "reveal": "always",
             "panel": "new"
         }
       },
       {
         "label": "mochitest",
-        "args": ["${relativeFile}"],
+        "args": ["mochitest", "${relativeFile}"],
         "problemMatcher": {
           "fileLocation": ["relative", "${workspaceRoot}"],
           "pattern": {
               "regexp": "^.*\\s+(TEST-UNEXPECTED-FAIL|TEST-UNEXPECTED-PASS)\\s+\\|\\s+([^\\s]*)\\s+\\|\\s+(.*)$",
               "severity": 1,
               "file": 2,
               "message": 3
           }
         },
         "presentation": {
             "reveal": "always",
             "panel": "new"
         }
       },
       {
         "label": "reftest",
-        "args": ["${relativeFile}"],
+        "args": ["reftest", "${relativeFile}"],
         "problemMatcher": {
           "fileLocation": ["absolute"],
           "pattern": {
               "regexp": "^.*\\s+(TEST-UNEXPECTED-FAIL|TEST-UNEXPECTED-PASS)\\s+\\|\\s+file:\/\/([^\\s]*)\\s+==\\s+[^\\s]*\\s+\\|\\s+(.*)$",
               "severity": 1,
               "file": 2,
               "message": 3
           }
         },
         "presentation": {
             "reveal": "always",
             "panel": "new"
         }
       },
       {
         "label": "xpcshell-test",
-        "args": ["${relativeFile}", "--sequential"],
+        "args": ["xpcshell-test", "${relativeFile}", "--sequential"],
         "problemMatcher": {
           "fileLocation": ["relative", "${workspaceRoot}"],
           "pattern": {
               "regexp": "^.*\\s+(FAIL|ERROR)\\s+\\[([^\\s]*)\\s+:\\s+(\\d+)\\]\\s+(.*)$",
               "severity": 1,
               "file": 2,
               "location": 3,
               "message": 4