Bug 1467618 [wpt PR 11390] - [PageLifecycle] Fix WPT test by hiding the page before freezing, a=testonly
authorFadi Meawad <fmeawad@chromium.org>
Tue, 26 Jun 2018 02:46:19 +0000
changeset 424258 56a163e7e3d3737efb20ae167d099496d41ebe6b
parent 424257 18e63010fbba33546d6e8092d021e58bcc7f6bbb
child 424259 1737cf06a0e63e5eb12a00c1e5c4cec8ab73afab
push id104753
push userarchaeopteryx@coole-files.de
push dateThu, 28 Jun 2018 12:34:45 +0000
treeherdermozilla-inbound@fe94281f7c25 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1467618, 11390, 837709, 848604, 1089354, 565031
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1467618 [wpt PR 11390] - [PageLifecycle] Fix WPT test by hiding the page before freezing, a=testonly Automatic update from web-platform-tests[PageLifecycle] Fix WPT test by hiding the page before freezing Freezing can only work on hidden pages, currently there is no easy way in webdriver that allows us to hide the page. A new webdriver API is in the works to enable that, but meanwhile, for all testing API, we have to couple hiding with freezing. This CL does that and reenables the test with Network Service. Bug: 837709, 848604 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ib5c513aefb219cef38a563be81fe8abf4b354051 Reviewed-on: https://chromium-review.googlesource.com/1089354 Commit-Queue: Fadi Meawad <fmeawad@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#565031} -- wpt-commits: 8121170bf45471a35105d12f6bf8a070216d1db6 wpt-pr: 11390
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/lifecycle/freeze.html
testing/web-platform/tests/lifecycle/resources/window.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -588731,25 +588731,25 @@
    "3215b6729d83ca2841baf6eb33445eb07e0a7c25",
    "testharness"
   ],
   "keyboard-map/keyboard-map-https.html": [
    "28b559875ce9514702d181cb4cb5e0a207083e2d",
    "testharness"
   ],
   "lifecycle/freeze.html": [
-   "aca6ab2b23924ff891dc2abc26eb3067ad099e5b",
+   "79f45af08ff1cfe5c29d318fe6a32d281e990960",
    "testharness"
   ],
   "lifecycle/resources/foo.txt": [
    "b909d6288b51d2b2dfe06382f057a5892826949b",
    "support"
   ],
   "lifecycle/resources/window.html": [
-   "3c839ba3697d5ce8bcda99824af7dea7b37534c1",
+   "63fc6c451359b4efc3a72c9908d71dd999e43122",
    "support"
   ],
   "longtask-timing/OWNERS": [
    "30a9c29ba53bac131c0cca801c01dddb4779824e",
    "support"
   ],
   "longtask-timing/longtask-attributes.html": [
    "247359327818f59871be00d22942f6ecde5281a7",
--- a/testing/web-platform/tests/lifecycle/freeze.html
+++ b/testing/web-platform/tests/lifecycle/freeze.html
@@ -1,17 +1,18 @@
 <!DOCTYPE html>
 <meta charset="utf-8">
 <title>TestDriver freeze method</title>
 <script src="/resources/testharness.js"></script>
 <script src="/resources/testharnessreport.js"></script>
 
 <script>
 var test = async_test('Test freeze callback.');
-var childWindow = window.open('resources/window.html', 'Child Window');
+window.open('resources/window.html', 'Child Window');
+
 var total_steps = 0;
 
 const StepStatus = {
   ADDED: 0,
   SUCCESS: 1,
   FAIL: 2,
 };
 
--- a/testing/web-platform/tests/lifecycle/resources/window.html
+++ b/testing/web-platform/tests/lifecycle/resources/window.html
@@ -51,16 +51,15 @@ window.document.addEventListener("freeze
   testFetch(false /* keepalive */);
   // Testing XHR, both sync and async should fail.
   testXHR(true /* async */);
   testXHR(false /* sync */);
   window.opener.step_success(freezingStepName);
 });
 
 onload = function() {
-  window.opener.focus();
   window.opener.add_step(freezingStepName);
   test_driver.freeze();
 };
 
 </script>
 </body>
 </html>
\ No newline at end of file