Bug 1525492 - [release 123] Monospace conditional panel and expressions (#7839). r=dwalsh
☠☠ backed out by d7e70a8d8b18 ☠ ☠
authorDavid Walsh <davidwalsh83@gmail.com>
Tue, 05 Feb 2019 18:26:22 -0800
changeset 457433 56233844989bcc9ffc1dc8e5dca0a6a82ef1e2f7
parent 457432 4167367cbc8c17b1d381185d083b166c5d28954a
child 457434 68a6f270afcf6eb8db09699b2ecaf92adc6200b9
push id111727
push userjlaster@mozilla.com
push dateWed, 06 Feb 2019 19:27:21 +0000
treeherdermozilla-inbound@e97ff8f77380 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdwalsh
bugs1525492
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1525492 - [release 123] Monospace conditional panel and expressions (#7839). r=dwalsh
devtools/client/debugger/new/dist/debugger.css
devtools/client/debugger/new/src/components/Editor/ConditionalPanel.css
devtools/client/debugger/new/src/components/SecondaryPanes/Expressions.css
--- a/devtools/client/debugger/new/dist/debugger.css
+++ b/devtools/client/debugger/new/dist/debugger.css
@@ -3031,16 +3031,20 @@ menuseparator {
   width: calc(100% - 4em);
   border: none;
   background: var(--theme-toolbar-background);
   font-size: 14px;
   color: var(--theme-conditional-breakpoint-color);
   line-height: 30px;
 }
 
+.conditional-breakpoint-panel input:not(:placeholder-shown) {
+  font-family: var(--monospace-font-family);
+}
+
 .conditional-breakpoint-panel input:focus {
   outline-width: 0;
 }
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */
 
 .editor-wrapper {
@@ -3740,18 +3744,18 @@ html[dir="rtl"] .breakpoints-list .break
 .expression-content .tree-node {
   overflow-x: hidden;
 }
 
 .expression-content .tree-node[data-expandable="false"][aria-level="1"] {
   padding-inline-start: 10px;
 }
 
-.expression-input {
-  max-width: 50%;
+.input-expression:not(:placeholder-shown) {
+  font-family: var(--monospace-font-family);
 }
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */
 
 .frames [role="list"] .frames-group .group,
 .frames [role="list"] .frames-group .group .location {
   font-weight: 500;
--- a/devtools/client/debugger/new/src/components/Editor/ConditionalPanel.css
+++ b/devtools/client/debugger/new/src/components/Editor/ConditionalPanel.css
@@ -28,11 +28,15 @@
   width: calc(100% - 4em);
   border: none;
   background: var(--theme-toolbar-background);
   font-size: 14px;
   color: var(--theme-conditional-breakpoint-color);
   line-height: 30px;
 }
 
+.conditional-breakpoint-panel input:not(:placeholder-shown) {
+  font-family: var(--monospace-font-family);
+}
+
 .conditional-breakpoint-panel input:focus {
   outline-width: 0;
 }
--- a/devtools/client/debugger/new/src/components/SecondaryPanes/Expressions.css
+++ b/devtools/client/debugger/new/src/components/SecondaryPanes/Expressions.css
@@ -111,11 +111,11 @@
 .expression-content .tree-node {
   overflow-x: hidden;
 }
 
 .expression-content .tree-node[data-expandable="false"][aria-level="1"] {
   padding-inline-start: 10px;
 }
 
-.expression-input {
-  max-width: 50%;
+.input-expression:not(:placeholder-shown) {
+  font-family: var(--monospace-font-family);
 }