Bug 1593131 - part5 : use unreachable assertion to replace debug log. r=chunmin
authorAlastor Wu <alwu@mozilla.com>
Thu, 14 Nov 2019 00:34:44 +0000
changeset 502054 55fe1b2e71c4c12aee2f132db87a46e0bf5fa8f3
parent 502053 103ad9fe9feaba13a65fc544567f45aa37161504
child 502055 f0ceeb68fff9ceb3d8ec9f7915695a8ed8ae9e27
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerschunmin
bugs1593131
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1593131 - part5 : use unreachable assertion to replace debug log. r=chunmin To make sure it never happens. Differential Revision: https://phabricator.services.mozilla.com/D52707
dom/media/mediacontrol/MediaControlKeysEvent.cpp
--- a/dom/media/mediacontrol/MediaControlKeysEvent.cpp
+++ b/dom/media/mediacontrol/MediaControlKeysEvent.cpp
@@ -63,17 +63,17 @@ void MediaControlKeysHandler::OnKeyPress
       }
       return;
     }
     case MediaControlKeysEvent::eNext:
     case MediaControlKeysEvent::ePrev:
       // TODO : implement related controller functions.
       return;
     default:
-      LOG("Error : undefined event!");
+      MOZ_ASSERT_UNREACHABLE("Error : undefined event!");
       return;
   }
 }
 
 NS_IMPL_ISUPPORTS0(MediaControlKeysEventSource)
 
 void MediaControlKeysEventSource::AddListener(
     MediaControlKeysEventListener* aListener) {