Bug 1497546 - Disable new behavior of keyCode and charCode of keypress event r=smaug a=Aryx
authorMasayuki Nakano <masayuki@d-toybox.com>
Tue, 09 Oct 2018 21:04:37 +0300
changeset 440309 550aa5330baf471ec1b9c6a05f4a598bec88ebf6
parent 440244 77491723486d3fb28d0001d2c603145696560ce7
child 440325 4845f02cf3545f00f4a6887a92455b3917296dee
push id108777
push userrgurzau@mozilla.com
push dateTue, 09 Oct 2018 22:05:52 +0000
treeherdermozilla-inbound@38890d8fa254 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmaug, Aryx
bugs1497546, 1479964
milestone64.0a1
first release with
nightly linux32
550aa5330baf / 64.0a1 / 20181009183338 / files
nightly linux64
550aa5330baf / 64.0a1 / 20181009183338 / files
nightly mac
550aa5330baf / 64.0a1 / 20181009183338 / files
nightly win32
550aa5330baf / 64.0a1 / 20181009183338 / files
nightly win64
550aa5330baf / 64.0a1 / 20181009183338 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1497546 - Disable new behavior of keyCode and charCode of keypress event r=smaug a=Aryx Summary: The fix of bug 1479964 breaks some web apps using Google Closure including Google's apps. So, for Nightly testers, we should disable the new behavior until Google Closure fixes it or we can disable the new behavior per web apps. Reviewers: smaug Reviewed By: smaug Bug #: 1497546 Differential Revision: https://phabricator.services.mozilla.com/D8090
modules/libpref/init/StaticPrefList.h
--- a/modules/libpref/init/StaticPrefList.h
+++ b/modules/libpref/init/StaticPrefList.h
@@ -176,27 +176,21 @@ VARCACHE_PREF(
   "dom.animations-api.timelines.enabled",
    dom_animations_api_timelines_enabled,
   bool, PREF_VALUE
 )
 #undef PREF_VALUE
 
 // If this is true, "keypress" event's keyCode value and charCode value always
 // become same if the event is not created/initialized by JS.
-#ifdef RELEASE_OR_BETA
-# define PREF_VALUE false
-#else
-# define PREF_VALUE true
-#endif
 VARCACHE_PREF(
   "dom.keyboardevent.keypress.set_keycode_and_charcode_to_same_value",
    dom_keyboardevent_keypress_set_keycode_and_charcode_to_same_value,
-  bool, PREF_VALUE
+  bool, false
 )
-#undef PREF_VALUE
 
 // NOTE: This preference is used in unit tests. If it is removed or its default
 // value changes, please update test_sharedMap_var_caches.js accordingly.
 VARCACHE_PREF(
   "dom.webcomponents.shadowdom.report_usage",
    dom_webcomponents_shadowdom_report_usage,
   bool, false
 )