Bug 1318171 - Catch all throwables in SearchEngineManager.createEngineFromLocale; r=sebastian
authorGeoff Brown <gbrown@mozilla.com>
Tue, 29 Nov 2016 16:51:31 -0700
changeset 324700 539af8b2ccc96cfb689534178b1e59cd9cf8ba95
parent 324699 a3c15e0b3c4ca1a8f3f3cae1e35bdae18696f6f3
child 324701 9271347b07d201df26cdffde75483c0b0001528c
push id84483
push usergbrown@mozilla.com
push dateTue, 29 Nov 2016 23:51:47 +0000
treeherdermozilla-inbound@539af8b2ccc9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssebastian
bugs1318171
milestone53.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1318171 - Catch all throwables in SearchEngineManager.createEngineFromLocale; r=sebastian
mobile/android/base/java/org/mozilla/gecko/search/SearchEngineManager.java
--- a/mobile/android/base/java/org/mozilla/gecko/search/SearchEngineManager.java
+++ b/mobile/android/base/java/org/mozilla/gecko/search/SearchEngineManager.java
@@ -581,17 +581,17 @@ public class SearchEngineManager impleme
                 // can happen with :hidden plugins
                 if (pluginIn != null) {
                   final SearchEngine engine = createEngineFromInputStream(identifier, pluginIn);
                   if (engine != null && engine.getName().equals(name)) {
                       return engine;
                   }
                 }
             }
-        } catch (Exception e) {
+        } catch (Throwable e) {
             Log.e(LOG_TAG, "Error creating shipped search engine from name: " + name, e);
         } finally {
             try {
                 br.close();
             } catch (IOException e) {
                 // Ignore.
             }
         }