Bug 1594520 - Avoid duplication in .vscode/tasks.json r=jya
authorTed Campbell <tcampbell@mozilla.com>
Tue, 12 Nov 2019 15:02:23 +0000
changeset 501686 530c4ab772a674e636b56cd5147a0773009cf9a3
parent 501685 6965500520e780708c1f1ccae7df92aee5d7d5ef
child 501687 57a4794a87f25c62f04126350416dc498ac03584
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjya
bugs1594520
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1594520 - Avoid duplication in .vscode/tasks.json r=jya These options default to outer contexts so we don't need to repeat ourselves. We were already setting the top level values anyways. Differential Revision: https://phabricator.services.mozilla.com/D52081
.vscode/tasks.json
--- a/.vscode/tasks.json
+++ b/.vscode/tasks.json
@@ -1,57 +1,46 @@
 {
     // See https://go.microsoft.com/fwlink/?LinkId=733558
     // for the documentation about the tasks.json format
     "version": "2.0.0",
+    "type": "shell",
     "command": "${workspaceRoot}/mach",
     "windows": {
       "command": "\"\\mozilla-build\\start-shell.bat mach\""
     },
     "args": ["--log-no-times"],
     "echoCommand": true,
     "tasks": [
       {
         "label": "clobber-python",
-        "type":"shell",
-        "command": "${workspaceRoot}/mach",
-        "windows": {
-          "command": "\"\\mozilla-build\\start-shell.bat mach\""
-        },
         "args": ["clobber", "python"],
         "problemMatcher": []
       },
       {
         "label": "configure",
-        "type":"shell",
         "problemMatcher": []
       },
       {
         "label": "build",
-        "type":"shell",
         "problemMatcher": {
           "owner": "cpp",
           "fileLocation": "absolute",
           "pattern": {
             "regexp": "^.*?([^\\s]*)[:(](\\d+)[:,](\\d+)[)]?:\\s+(warning|error):\\s+(.*)$",
             "file": 1,
             "line": 2,
             "column": 3,
             "severity": 4,
             "message": 5
           }
         }
       },
       {
         "label": "build-binaries",
-        "type":"shell",
-        "command": "${workspaceRoot}/mach",
-        "windows": {
-          "command": "\"\\mozilla-build\\start-shell.bat mach\""
-        },
         "args": ["--log-no-times", "build", "binaries"],
         "problemMatcher": {
           "owner": "cpp",
           "fileLocation": "absolute",
           "pattern": {
             "regexp": "^(.*)[:(](\\d+)[:,](\\d+)[)]?:\\s+(warning|error):\\s+(.*)$",
             "file": 1,
             "line": 2,
@@ -62,79 +51,60 @@
         },
         "group": {
             "kind": "build",
             "isDefault": true
         }
       },
       {
         "label": "build-faster",
-        "type":"shell",
-        "command": "${workspaceRoot}/mach",
-        "windows": {
-          "command": "\"\\mozilla-build\\start-shell.bat mach\""
-        },
         "args": ["--log-no-times", "build", "faster"],
         "problemMatcher": {
           "owner": "cpp",
           "fileLocation": "absolute",
           "pattern": {
             "regexp": "^(.*)[:(](\\d+)[:,](\\d+)[)]?:\\s+(warning|error):\\s+(.*)$",
             "file": 1,
             "line": 2,
             "column": 3,
             "severity": 4,
             "message": 5
           }
         }
       },
       {
         "label": "run",
-        "type":"shell",
         "args": ["-purgecaches"],
         "problemMatcher": []
       },
       {
         "label": "lint-wo",
-        "type":"shell",
-        "command": "${workspaceRoot}/mach",
-        "windows": {
-          "command": "\"\\mozilla-build\\start-shell.bat mach\""
-        },
         "args": ["lint", "-wo"],
         "problemMatcher": ["$eslint-stylish"]
       },
       {
         "label": "eslint",
-        "type": "shell",
         "problemMatcher": ["$eslint-stylish"]
       },
       {
         "label": "eslint-fix",
-        "type":"shell",
-        "command": "${workspaceRoot}/mach",
-        "windows": {
-          "command": "\"\\mozilla-build\\start-shell.bat mach\""
-        },
         "args": ["eslint", "--fix", "${file}"],
         "problemMatcher": ["$eslint-stylish"]
       },
       {
         "label": "test",
-        "type":"shell",
         "args": ["${relativeFile}"],
         "group":"test",
         "presentation": {
             "reveal": "always",
             "panel": "new"
         }
       },
       {
         "label": "mochitest",
-        "type":"shell",
         "args": ["${relativeFile}"],
         "problemMatcher": {
           "fileLocation": ["relative", "${workspaceRoot}"],
           "pattern": {
               "regexp": "^.*\\s+(TEST-UNEXPECTED-FAIL|TEST-UNEXPECTED-PASS)\\s+\\|\\s+([^\\s]*)\\s+\\|\\s+(.*)$",
               "severity": 1,
               "file": 2,
               "message": 3
@@ -142,17 +112,16 @@
         },
         "presentation": {
             "reveal": "always",
             "panel": "new"
         }
       },
       {
         "label": "reftest",
-        "type":"shell",
         "args": ["${relativeFile}"],
         "problemMatcher": {
           "fileLocation": ["absolute"],
           "pattern": {
               "regexp": "^.*\\s+(TEST-UNEXPECTED-FAIL|TEST-UNEXPECTED-PASS)\\s+\\|\\s+file:\/\/([^\\s]*)\\s+==\\s+[^\\s]*\\s+\\|\\s+(.*)$",
               "severity": 1,
               "file": 2,
               "message": 3
@@ -160,17 +129,16 @@
         },
         "presentation": {
             "reveal": "always",
             "panel": "new"
         }
       },
       {
         "label": "xpcshell-test",
-        "type":"shell",
         "args": ["${relativeFile}", "--sequential"],
         "problemMatcher": {
           "fileLocation": ["relative", "${workspaceRoot}"],
           "pattern": {
               "regexp": "^.*\\s+(FAIL|ERROR)\\s+\\[([^\\s]*)\\s+:\\s+(\\d+)\\]\\s+(.*)$",
               "severity": 1,
               "file": 2,
               "location": 3,