Bug 1594520 - Use full path to mach in .vscode/tasks.json on Windows r=jya
authorTed Campbell <tcampbell@mozilla.com>
Tue, 12 Nov 2019 12:54:18 +0000
changeset 501689 519ad74e9d7be8ea39e7c451cc346e04b7f7adb3
parent 501688 27ab68adb7d07cf04405396a8fd8b97fe0b67d1b
child 501690 ef26ae2ee4c22fc88d6590244862066f1974c6ce
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjya
bugs1594520
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1594520 - Use full path to mach in .vscode/tasks.json on Windows r=jya Current versions of mozilla-build ignore the current working directory so use full path to mach. Due to path mangling issues copying from vscode -> powershell -> msys-bash, I used a PowerShell fragment to translate the path. Differential Revision: https://phabricator.services.mozilla.com/D52084
.vscode/tasks.json
--- a/.vscode/tasks.json
+++ b/.vscode/tasks.json
@@ -1,18 +1,23 @@
 {
     // See https://go.microsoft.com/fwlink/?LinkId=733558
     // for the documentation about the tasks.json format
     "version": "2.0.0",
     "type": "shell",
     "command": "${workspaceFolder}/mach",
+    "args": ["--log-no-times"],
     "windows": {
-      "command": "\"\\mozilla-build\\start-shell.bat mach\""
+      "command": "/mozilla-build/start-shell.bat",
+      "args": [
+        // Use PowerShell to mangle path for mozilla-build environment
+        {"value": "$('${workspaceFolder}\\mach' -replace '\\\\','/')", "quoting": "weak"},
+        "--log-no-times"
+      ]
     },
-    "args": ["--log-no-times"],
     "tasks": [
       {
         "label": "clobber",
         "args": ["clobber"],
         "problemMatcher": []
       },
       {
         "label": "clobber-python",