Bug 1444940 [wpt PR 9923] - Don't pixel-snap the top and bottom of lines., a=testonly
authorMorten Stenshorne <mstensho@chromium.org>
Mon, 26 Mar 2018 15:39:12 +0000
changeset 411234 50b4429fd894941c919d94b58fb55f197131b961
parent 411233 c4b8c19400fd449f2067223dc3aa8bfc161751c8
child 411235 db476a91387c5deb1d3e89ba1ecaa777650d1be0
push id101593
push userjames@hoppipolla.co.uk
push dateSat, 31 Mar 2018 22:09:06 +0000
treeherdermozilla-inbound@feb3750f2fac [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1444940, 818873, 954022, 542080
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1444940 [wpt PR 9923] - Don't pixel-snap the top and bottom of lines., a=testonly Automatic update from web-platform-testsDon't pixel-snap the top and bottom of lines. That might cause incorrect detection of overflow, since the height of the block isn't pixel-snapped. Bug: 818873 Change-Id: I864be9dfedf6f008fe19ce02088ac6488ec274d0 Reviewed-on: https://chromium-review.googlesource.com/954022 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#542080} wpt-commits: 6cca5247026215cbea027426cb22f4e517b43566 wpt-pr: 9923 wpt-commits: 6cca5247026215cbea027426cb22f4e517b43566 wpt-pr: 9923
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/css/CSS2/linebox/fractional-line-height.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -54226,16 +54226,28 @@
       [
        "/css/CSS2/linebox/empty-inline-003-ref.xht",
        "=="
       ]
      ],
      {}
     ]
    ],
+   "css/CSS2/linebox/fractional-line-height.html": [
+    [
+     "/css/CSS2/linebox/fractional-line-height.html",
+     [
+      [
+       "/css/reference/nothing.html",
+       "=="
+      ]
+     ],
+     {}
+    ]
+   ],
    "css/CSS2/linebox/inline-box-001.xht": [
     [
      "/css/CSS2/linebox/inline-box-001.xht",
      [
       [
        "/css/CSS2/linebox/inline-box-001-ref.xht",
        "=="
       ]
@@ -445801,16 +445813,20 @@
   "css/CSS2/linebox/empty-inline-003-ref.xht": [
    "12e0b8112d26a3d00d66e1fe77819f8cfa7c8ff2",
    "support"
   ],
   "css/CSS2/linebox/empty-inline-003.xht": [
    "7d267cb188014a18688e13806e095706f3f2d937",
    "reftest"
   ],
+  "css/CSS2/linebox/fractional-line-height.html": [
+   "d883c6dbf79c1da2c7a9a2261ec19eb6fc546082",
+   "reftest"
+  ],
   "css/CSS2/linebox/inline-box-001-ref.xht": [
    "55eee0833d9596605cb10d6bccfaedbe6f784027",
    "support"
   ],
   "css/CSS2/linebox/inline-box-001.xht": [
    "dbe55943f1a266512272b18338f80cf96b4e41ef",
    "reftest"
   ],
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/CSS2/linebox/fractional-line-height.html
@@ -0,0 +1,30 @@
+<!DOCTYPE html>
+<title>Container height calculation with fractional line height and fractional child height</title>
+<link rel="author" title="Morten Stenshorne" href="mstensho@chromium.org">
+<link rel="help" href="https://www.w3.org/TR/CSS22/visudet.html#line-height" title="10.8 Line height calculations: the 'line-height' and 'vertical-align' properties">
+<link rel="match" href="../../reference/nothing.html">
+<style>
+  .container { float:left; overflow:auto; width:50px; }
+  .container > span { display:inline-block; width:10px; }
+</style>
+<p>There should be nothing below.</p>
+
+<!-- None of these should not trigger a vertical scrollbar, because the height
+     of the overflow:auto container is auto, so it should make room for
+     whatever's inside. -->
+
+<div class="container" style="line-height:19.75px;">
+  <span style="height:100.25px;"></span>
+</div>
+
+<div class="container" style="line-height:19.75px;">
+  <span style="height:100.75px;"></span>
+</div>
+
+<div class="container" style="line-height:19.25px;">
+  <span style="height:100.25px;"></span>
+</div>
+
+<div class="container" style="line-height:19.25px;">
+  <span style="height:100.75px;"></span>
+</div>