mozilla-inbound: changeset 241237:4f898b4ffd633ed3dc2c75cd5e38e8016b2e3ea6

author	Nathan Froyd <froydnj@mozilla.com>
	Mon, 27 Apr 2015 07:55:32 -0400
changeset 241237	4f898b4ffd633ed3dc2c75cd5e38e8016b2e3ea6
parent 241236	d02374f93b37167b58a34a8f78ee785089027c3c
child 241238	f284c64e55371a5ecbbb86d0790e9ce418767ef8
push id	59061
push user	nfroyd@mozilla.com
push date	Mon, 27 Apr 2015 18:29:45 +0000
treeherder	mozilla-inbound@f284c64e5537 [default view] [failures only]
perfherder	[talos] [build metrics] [platform microbench] (compared to previous push)
reviewers	erahm
bugs	1158772
milestone	40.0a1
first release with	nightly linux32 1ad65cbeb2f4 / 40.0a1 / 20150429030202 / files nightly linux64 1ad65cbeb2f4 / 40.0a1 / 20150429030202 / files nightly mac 1ad65cbeb2f4 / 40.0a1 / 20150429030202 / files nightly win32 1ad65cbeb2f4 / 40.0a1 / 20150429030202 / files nightly win64 1ad65cbeb2f4 / 40.0a1 / 20150429030202 / files
last release without	nightly linux32 8aff0d2a7bc7 / 40.0a1 / 20150427030207 / files nightly linux64 8aff0d2a7bc7 / 40.0a1 / 20150427030207 / files nightly mac 8aff0d2a7bc7 / 40.0a1 / 20150427030207 / files nightly win32 8aff0d2a7bc7 / 40.0a1 / 20150427030207 / files nightly win64 8aff0d2a7bc7 / 40.0a1 / 20150427030207 / files

Bug 1158772 - fix non-idiomatic memset call in nsDeque.cpp; r=erahm Coverty complains that we're using sizeof(mData) here instead of sizeof(*mData). They're equivalent for all the architectures we care about, but go ahead and tidy up the syntax to silence the static analyzer.

xpcom/glue/nsDeque.cpp

file | annotate | diff | comparison | revisions

--- a/xpcom/glue/nsDeque.cpp
+++ b/xpcom/glue/nsDeque.cpp
@@ -130,17 +130,17 @@ nsDeque::SetDeallocator(nsDequeFunctor* 
 
 /**
  * Remove all items from container without destroying them.
  */
 void
 nsDeque::Empty()
 {
   if (mSize && mData) {
-    memset(mData, 0, mCapacity * sizeof(mData));
+    memset(mData, 0, mCapacity * sizeof(*mData));
   }
   mSize = 0;
   mOrigin = 0;
 }
 
 /**
  * Remove and delete all items from container
  */