☠☠ backed out by b3b9d24cdb97 ☠ ☠ | |
author | Trevor Saunders <tbsaunde@tbsaunde.org> |
Fri, 02 Sep 2016 15:36:22 -0400 | |
changeset 322843 | 4c58195d6bcf62a04f8f23b5c199b33db05808e7 |
parent 322842 | 8e5f19f19b7f51090ba93d21bae1210f89ba5497 |
child 322844 | cd68b5fd88a6922643c848148b7ecf12dacdd407 |
push id | 83989 |
push user | tsaunders@mozilla.com |
push date | Wed, 16 Nov 2016 23:06:07 +0000 |
treeherder | mozilla-inbound@916cbaf21a63 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | davidb |
bugs | 1270916 |
milestone | 53.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/accessible/base/AccEvent.h +++ b/accessible/base/AccEvent.h @@ -197,25 +197,35 @@ public: private: int32_t mStart; bool mIsInserted; nsString mModifiedText; friend class EventTree; }; +/** + * A base class for events related to tree mutation, either an AccMutation + * event, or an AccReorderEvent. + */ +class AccTreeMutationEvent : public AccEvent +{ +public: + AccTreeMutationEvent(uint32_t aEventType, Accessible* aTarget) : + AccEvent(aEventType, aTarget, eAutoDetect, eCoalesceReorder) {} +}; /** * Base class for show and hide accessible events. */ -class AccMutationEvent: public AccEvent +class AccMutationEvent: public AccTreeMutationEvent { public: AccMutationEvent(uint32_t aEventType, Accessible* aTarget) : - AccEvent(aEventType, aTarget, eAutoDetect, eCoalesceReorder) + AccTreeMutationEvent(aEventType, aTarget) { // Don't coalesce these since they are coalesced by reorder event. Coalesce // contained text change events. mParent = mAccessible->Parent(); } virtual ~AccMutationEvent() { } // Event @@ -293,22 +303,21 @@ private: friend class EventTree; }; /** * Class for reorder accessible event. Takes care about */ -class AccReorderEvent : public AccEvent +class AccReorderEvent : public AccTreeMutationEvent { public: explicit AccReorderEvent(Accessible* aTarget) : - AccEvent(::nsIAccessibleEvent::EVENT_REORDER, aTarget, - eAutoDetect, eCoalesceReorder) { } + AccTreeMutationEvent(::nsIAccessibleEvent::EVENT_REORDER, aTarget) { } virtual ~AccReorderEvent() { } // Event static const EventGroup kEventGroup = eReorderEvent; virtual unsigned int GetEventGroups() const override { return AccEvent::GetEventGroups() | (1U << eReorderEvent); }