Bug 1542980 - fixed js shell compilation error. r=jonco
authorYoshi Cheng-Hao Huang <allstars.chh@gmail.com>
Fri, 12 Apr 2019 08:58:42 +0000
changeset 469248 4c4e45853808229f832e32f6bcdbd4c92a72b13b
parent 469247 fc8e9758009c4e4cf9fbcd8750b1e1c0cadc14a4
child 469249 0cee09cf4016fa15f2d5904e2e1c9efc0f5032c8
push id112776
push usershindli@mozilla.com
push dateFri, 12 Apr 2019 16:20:17 +0000
treeherdermozilla-inbound@b4501ced5619 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjonco
bugs1542980, 1534967
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1542980 - fixed js shell compilation error. r=jonco This is from Bug 1534967, and the code is wrapped with compiler option `JS_MORE_DETERMINISTIC`, which is only enabled through '--enable-more-deterministic' in shell configure. Differential Revision: https://phabricator.services.mozilla.com/D26656
js/src/vm/Iteration.cpp
--- a/js/src/vm/Iteration.cpp
+++ b/js/src/vm/Iteration.cpp
@@ -519,18 +519,18 @@ static bool Snapshot(JSContext* cx, Hand
    *
    * We don't do this in the general case because (a) doing so is slow,
    * and (b) it also breaks the web, which expects enumeration order to
    * follow the order in which properties are added, in certain cases.
    * Since ECMA does not specify an enumeration order for objects, both
    * behaviors are technically correct to do.
    */
 
-  jsid* ids = props->begin();
-  size_t n = props->length();
+  jsid* ids = props.begin();
+  size_t n = props.length();
 
   RootedIdVector tmp(cx);
   if (!tmp.resize(n)) {
     return false;
   }
   PodCopy(tmp.begin(), ids, n);
 
   if (!MergeSort(ids, n, tmp.begin(), SortComparatorIds(cx))) {