Backed out changeset 2f3454d832c6 (bug 1372892) for breaking nightly signing - causing bug 1378744
authorCarsten "Tomcat" Book <cbook@mozilla.com>
Thu, 06 Jul 2017 14:53:35 +0200
changeset 367702 4bd7db49d22847111dff9c1dd63ed573903faa5b
parent 367599 018b3829d0a7f6944a5ae1489f3a64c9e2893909
child 367703 99991748fe35ab9ccf040951da09cea9eafcdad9
push id92302
push userkwierso@gmail.com
push dateThu, 06 Jul 2017 23:17:41 +0000
treeherdermozilla-inbound@2d821e7a39b7 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1372892, 1378744
milestone56.0a1
backs out2f3454d832c63aa871e6ea209fc7205f815b2b45
first release with
nightly linux32
4bd7db49d228 / 56.0a1 / 20170706130309 / files
nightly linux64
4bd7db49d228 / 56.0a1 / 20170706130309 / files
nightly mac
4bd7db49d228 / 56.0a1 / 20170706130327 / files
nightly win32
4bd7db49d228 / 56.0a1 / 20170706060058 / files
nightly win64
4bd7db49d228 / 56.0a1 / 20170706060058 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 2f3454d832c6 (bug 1372892) for breaking nightly signing - causing bug 1378744
taskcluster/taskgraph/create.py
--- a/taskcluster/taskgraph/create.py
+++ b/taskcluster/taskgraph/create.py
@@ -55,25 +55,21 @@ def create_tasks(taskgraph, label_to_tas
         # Using visit_postorder() here isn't the most efficient: we'll
         # block waiting for dependencies of task N to submit even though
         # dependencies for task N+1 may be finished. If we need to optimize
         # this further, we can build a graph of task dependencies and walk
         # that.
         for task_id in taskgraph.graph.visit_postorder():
             task_def = taskgraph.tasks[task_id].task
             attributes = taskgraph.tasks[task_id].attributes
-
-            # if this task has no dependencies *within* this taskgraph, make it
-            # depend on this decision task. If it has another dependency within
-            # the taskgraph, then it already implicitly depends on the decision
-            # task.  The result is that tasks do not start immediately. if this
-            # loop fails halfway through, none of the already-created tasks run.
-            if decision_task_id:
-                if not any(t in taskgraph.tasks for t in task_def.get('dependencies', [])):
-                    task_def.setdefault('dependencies', []).append(decision_task_id)
+            # if this task has no dependencies, make it depend on this decision
+            # task so that it does not start immediately; and so that if this loop
+            # fails halfway through, none of the already-created tasks run.
+            if decision_task_id and not task_def.get('dependencies'):
+                task_def['dependencies'] = [decision_task_id]
 
             task_def['taskGroupId'] = task_group_id
             task_def['schedulerId'] = scheduler_id
 
             # Wait for dependencies before submitting this.
             deps_fs = [fs[dep] for dep in task_def.get('dependencies', [])
                        if dep in fs]
             for f in futures.as_completed(deps_fs):