Bug 1543350 - don't shut-down taskqueue early. r=jya,mjf
authorAlex Chronopoulos <achronop@gmail.com>
Thu, 18 Apr 2019 08:23:59 +0000
changeset 470037 4aebb965d8a08a80389fa06b0521af15ec329044
parent 470036 0300023c259faa756c90bf52df9a132b5d504794
child 470038 f4de96f2d275f0bff16042ef322a69366b79cb81
push id112839
push userapavel@mozilla.com
push dateThu, 18 Apr 2019 21:50:57 +0000
treeherdermozilla-inbound@e0a826fcd85b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjya, mjf
bugs1543350
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1543350 - don't shut-down taskqueue early. r=jya,mjf Shutting down the taskqueue early prevents the decoder's tasks to be queued. A TaskQueue no longer requires to be explicitly shutdown it will shutdown when ref counter drops to zero. Differential Revision: https://phabricator.services.mozilla.com/D26929
dom/media/ipc/RemoteDecoderParent.cpp
--- a/dom/media/ipc/RemoteDecoderParent.cpp
+++ b/dom/media/ipc/RemoteDecoderParent.cpp
@@ -154,19 +154,16 @@ mozilla::ipc::IPCResult RemoteDecoderPar
 
 void RemoteDecoderParent::ActorDestroy(ActorDestroyReason aWhy) {
   MOZ_ASSERT(!mDestroyed);
   MOZ_ASSERT(OnManagerThread());
   if (mDecoder) {
     mDecoder->Shutdown();
     mDecoder = nullptr;
   }
-  if (mDecodeTaskQueue) {
-    mDecodeTaskQueue->BeginShutdown();
-  }
 }
 
 void RemoteDecoderParent::Error(const MediaResult& aError) {
   MOZ_ASSERT(OnManagerThread());
   if (!mDestroyed) {
     Unused << SendError(aError);
   }
 }