Bug 1092001 - Fix warnings in dom/tv and mark as FAIL_ON_WARNINGS. r=ehsan
authorChris Peterson <cpeterson@mozilla.com>
Wed, 29 Oct 2014 21:52:41 -0700
changeset 213474 4a4eb24614d134748309b84d3104fa0deeb91b9b
parent 213473 d10109f1b0c268a22039d449c19431e5ccd5e08f
child 213475 f3d36cf13ac10855861b82acd6f82692af675a3f
push id51240
push usercpeterson@mozilla.com
push dateSat, 01 Nov 2014 02:14:12 +0000
treeherdermozilla-inbound@4a4eb24614d1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersehsan
bugs1092001
milestone36.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1092001 - Fix warnings in dom/tv and mark as FAIL_ON_WARNINGS. r=ehsan
dom/tv/FakeTVService.cpp
dom/tv/moz.build
--- a/dom/tv/FakeTVService.cpp
+++ b/dom/tv/FakeTVService.cpp
@@ -175,17 +175,17 @@ FakeTVService::SetSource(const nsAString
     }
   }
 
   nsCOMPtr<nsIRunnable> runnable =
     new TVServiceNotifyRunnable(aCallback, nullptr, nsITVServiceCallback::TV_ERROR_FAILURE);
   return NS_DispatchToCurrentThread(runnable);
 }
 
-class EITBroadcastedCallback : public nsITimerCallback
+class EITBroadcastedCallback MOZ_FINAL : public nsITimerCallback
 {
 public:
   NS_DECL_ISUPPORTS
 
   EITBroadcastedCallback(const nsAString& aTunerId,
                          const nsAString& aSourceType,
                          nsITVSourceListener* aSourceListener,
                          nsITVChannelData* aChannelData)
@@ -223,17 +223,17 @@ private:
   nsString mTunerId;
   nsString mSourceType;
   nsCOMPtr<nsITVSourceListener> mSourceListener;
   nsCOMPtr<nsITVChannelData> mChannelData;
 };
 
 NS_IMPL_ISUPPORTS(EITBroadcastedCallback, nsITimerCallback)
 
-class ScanCompleteCallback : public nsITimerCallback
+class ScanCompleteCallback MOZ_FINAL : public nsITimerCallback
 {
 public:
   NS_DECL_ISUPPORTS
 
   ScanCompleteCallback(const nsAString& aTunerId,
                        const nsAString& aSourceType,
                        nsITVSourceListener* aSourceListener)
     : mTunerId(aTunerId)
--- a/dom/tv/moz.build
+++ b/dom/tv/moz.build
@@ -40,8 +40,10 @@ XPIDL_MODULE = 'dom_tv'
 
 MOCHITEST_MANIFESTS += ['test/mochitest/mochitest.ini']
 
 XPCSHELL_TESTS_MANIFESTS += ['test/xpcshell/xpcshell.ini']
 
 include('/ipc/chromium/chromium-config.mozbuild')
 
 FINAL_LIBRARY = 'xul'
+
+FAIL_ON_WARNINGS = True