Bug 1060930 - Mark the HTML5 Parser constructors with one argument as explicit; r=hsivonen
☠☠ backed out by 912065e39dc3 ☠ ☠
authorEhsan Akhgari <ehsan@mozilla.com>
Mon, 01 Sep 2014 18:02:08 -0400
changeset 202829 4912d451011aba90f1271f8cb2c72d1777191f0e
parent 202828 bdacbf45323811518b27da14222ec6630f72f5b2
child 202830 b5af5cbdac3fdbcebe6df0b8a8c04f5c888aa095
push id48506
push usereakhgari@mozilla.com
push dateMon, 01 Sep 2014 22:05:00 +0000
treeherdermozilla-inbound@a8cddc6bdffc [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewershsivonen
bugs1060930
milestone34.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1060930 - Mark the HTML5 Parser constructors with one argument as explicit; r=hsivonen
parser/html/nsHtml5ElementName.h
parser/html/nsHtml5HtmlAttributes.h
--- a/parser/html/nsHtml5ElementName.h
+++ b/parser/html/nsHtml5ElementName.h
@@ -69,17 +69,17 @@ class nsHtml5ElementName
 
     int32_t getGroup();
     bool isCustom();
     static nsHtml5ElementName* elementNameByBuffer(char16_t* buf, int32_t offset, int32_t length, nsHtml5AtomTable* interner);
   private:
     static int32_t bufToHash(char16_t* buf, int32_t len);
     nsHtml5ElementName(nsIAtom* name, nsIAtom* camelCaseName, int32_t flags);
   protected:
-    nsHtml5ElementName(nsIAtom* name);
+    explicit nsHtml5ElementName(nsIAtom* name);
   public:
     virtual void release();
     virtual ~nsHtml5ElementName();
     virtual nsHtml5ElementName* cloneElementName(nsHtml5AtomTable* interner);
     static nsHtml5ElementName* ELT_A;
     static nsHtml5ElementName* ELT_B;
     static nsHtml5ElementName* ELT_G;
     static nsHtml5ElementName* ELT_I;
--- a/parser/html/nsHtml5HtmlAttributes.h
+++ b/parser/html/nsHtml5HtmlAttributes.h
@@ -61,17 +61,17 @@ class nsHtml5HtmlAttributes
   public:
     static nsHtml5HtmlAttributes* EMPTY_ATTRIBUTES;
   private:
     int32_t mode;
     int32_t length;
     autoJArray<nsHtml5AttributeName*,int32_t> names;
     autoJArray<nsString*,int32_t> values;
   public:
-    nsHtml5HtmlAttributes(int32_t mode);
+    explicit nsHtml5HtmlAttributes(int32_t mode);
     ~nsHtml5HtmlAttributes();
     int32_t getIndex(nsHtml5AttributeName* name);
     nsString* getValue(nsHtml5AttributeName* name);
     int32_t getLength();
     nsIAtom* getLocalNameNoBoundsCheck(int32_t index);
     int32_t getURINoBoundsCheck(int32_t index);
     nsIAtom* getPrefixNoBoundsCheck(int32_t index);
     nsString* getValueNoBoundsCheck(int32_t index);