Backed out changeset 5bc40c94645c (bug 880752) for jetpack bustage
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Fri, 02 Aug 2013 12:25:37 +0200
changeset 141214 489187b2309d9b8b301c89ca9c72dfb709c101a0
parent 141213 5bc40c94645c79c13dbd75cb1879d5205bc34868
child 141215 2a567b5e955d02d831a99ddc6be14ae4d145d60d
push id32022
push userryanvm@gmail.com
push dateFri, 02 Aug 2013 23:54:23 +0000
treeherdermozilla-inbound@94e7bd6f097f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs880752
milestone25.0a1
backs out5bc40c94645c79c13dbd75cb1879d5205bc34868
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 5bc40c94645c (bug 880752) for jetpack bustage
toolkit/devtools/Console.jsm
--- a/toolkit/devtools/Console.jsm
+++ b/toolkit/devtools/Console.jsm
@@ -106,22 +106,21 @@ function getCtorName(aObj) {
   return Object.prototype.toString.call(aObj).slice(8, -1);
 }
 
 /**
  * A single line stringification of an object designed for use by humans
  *
  * @param {any} aThing
  *        The object to be stringified
- * @param {boolean} aAllowNewLines
  * @return {string}
  *        A single line representation of aThing, which will generally be at
  *        most 80 chars long
  */
-function stringify(aThing, aAllowNewLines) {
+function stringify(aThing) {
   if (aThing === undefined) {
     return "undefined";
   }
 
   if (aThing === null) {
     return "null";
   }
 
@@ -141,20 +140,17 @@ function stringify(aThing, aAllowNewLine
     }
     return type + json;
   }
 
   if (typeof aThing == "function") {
     return aThing.toString().replace(/\s+/g, " ");
   }
 
-  let str = aThing.toString();
-  if (!aAllowNewLines) {
-    str = str.replace(/\n/g, "|");
-  }
+  let str = aThing.toString().replace(/\n/g, "|");
   return str;
 }
 
 /**
  * Create a simple debug representation of a given element.
  *
  * @param {nsIDOMElement} aElement
  *        The element to debug
@@ -464,19 +460,19 @@ function createDumper(aLevel) {
   return function() {
     if (!shouldLog(aLevel, this.maxLogLevel)) {
       return;
     }
     let args = Array.prototype.slice.call(arguments, 0);
     let frame = getStack(Components.stack.caller, 1)[0];
     sendConsoleAPIMessage(aLevel, frame, args);
     let data = args.map(function(arg) {
-      return stringify(arg, true);
+      return stringify(arg);
     });
-    dumpMessage(this, aLevel, data.join(" "));
+    dumpMessage(this, aLevel, data.join(", "));
   };
 }
 
 /**
  * Create a function which will output more detailed level of output when
  * used as a logging function
  *
  * @param {string} aLevel