Backed out changeset a3dc461058c5 (bug 1544682) for perma failures on toolkit/components/extensions/test/browser/browser_ext_themes_separators.js. CLOSED TREE
authorRazvan Maries <rmaries@mozilla.com>
Fri, 19 Apr 2019 00:29:45 +0300
changeset 470115 47f2ce075ee679590b11f34efbfc6152e418d35e
parent 470114 cf8038ca2da37288169690932880e737024d5afc
child 470116 e6eaf8ab500a17c4ed1bb2ea84e525d9e825ce3a
push id112843
push useraiakab@mozilla.com
push dateFri, 19 Apr 2019 09:50:22 +0000
treeherdermozilla-inbound@c06f27cbfe40 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1544682
milestone68.0a1
backs outa3dc461058c55ccfb3865ccb26c256ff7edb4896
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset a3dc461058c5 (bug 1544682) for perma failures on toolkit/components/extensions/test/browser/browser_ext_themes_separators.js. CLOSED TREE
browser/themes/osx/browser.css
browser/themes/shared/browser.inc.css
browser/themes/windows/browser-aero.css
--- a/browser/themes/osx/browser.css
+++ b/browser/themes/osx/browser.css
@@ -52,22 +52,21 @@
 /*
   This is a workaround for Bug 1482157
   -moz-appearance: toolbox; makes the macOS sheets attached to the element's
   bottom border. We cannot put this property on the toolbox itself as it
   cancels all backgrounds that are there, so we set it on the toolbox bottom
   border.
 */
 #navigator-toolbox::after {
-  content: "";
-  display: -moz-box;
   -moz-appearance: toolbox;
   height: 1px;
-  margin-top: -1px;
-  opacity: 0;
+  /* use inset box-shadow instead of border because -moz-appearance hides the border */
+  border: none;
+  box-shadow: inset 0 -1px var(--chrome-content-separator-color);
 }
 
 #tabbrowser-tabs {
   --tab-line-color: #0a84ff;
 }
 
 #navigator-toolbox toolbarbutton:-moz-lwtheme {
   color: inherit;
--- a/browser/themes/shared/browser.inc.css
+++ b/browser/themes/shared/browser.inc.css
@@ -34,21 +34,23 @@
 /* Increase contrast of UI links on dark themes */
 
 :root[lwt-popup-brighttext] panel .text-link {
   color: @lwtPopupBrighttextLinkColor@;
 }
 
 /* Toolbar / content area border */
 
-#navigator-toolbox {
+#navigator-toolbox::after {
+  content: "";
+  display: -moz-box;
   border-bottom: 1px solid var(--chrome-content-separator-color);
 }
 
-:root[customizing] #navigator-toolbox {
+:root[customizing] #navigator-toolbox::after {
   border-bottom-style: none;
 }
 
 :root[sessionrestored] #nav-bar:-moz-lwtheme {
   transition: @themeTransition@;
 }
 
 /* Bookmark toolbar */
--- a/browser/themes/windows/browser-aero.css
+++ b/browser/themes/windows/browser-aero.css
@@ -303,28 +303,17 @@
     /* Vertical toolbar border */
     #main-window[sizemode=normal] .browser-toolbar:not(.titlebar-color):not(:-moz-lwtheme),
     #main-window[sizemode=normal] .browser-toolbar:-moz-lwtheme {
       border-left: 1px solid @glassShadowColor@;
       border-right: 1px solid @glassShadowColor@;
       background-clip: padding-box;
     }
 
-    #navigator-toolbox::after {
-      content: "";
-      display: -moz-box;
-      border-bottom: 1px solid var(--chrome-content-separator-color);
-    }
-
-    #navigator-toolbox,
-    :root[customizing] #navigator-toolbox::after {
-      border-bottom-style: none;
-    }
-
-    :root[sizemode=normal] #navigator-toolbox::after {
+    #main-window[sizemode=normal] #navigator-toolbox::after {
       box-shadow: 1px 0 0 @glassShadowColor@, -1px 0 0 @glassShadowColor@;
       margin-left: 1px;
       margin-right: 1px;
     }
 
     #main-window[sizemode=normal] #browser-border-start,
     #main-window[sizemode=normal] #browser-border-end {
       display: -moz-box;