Bug 1497393 Part 4 - Suppress event handling at the usual times in server when replaying, r=loganfsmyth.
authorBrian Hackett <bhackett1024@gmail.com>
Sat, 09 Mar 2019 16:40:40 -1000
changeset 468288 47c9d34dbef10537efde4d8915571307812a6283
parent 468287 d0c8809342e494ce691699f7cadae2f872f6700d
child 468289 6c051fac78f3947be26546bab32f75cf6d25974a
push id112699
push userbhackett@mozilla.com
push dateSun, 07 Apr 2019 03:06:36 +0000
treeherdermozilla-inbound@46a995ea433f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersloganfsmyth
bugs1497393
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1497393 Part 4 - Suppress event handling at the usual times in server when replaying, r=loganfsmyth. Differential Revision: https://phabricator.services.mozilla.com/D22860
devtools/server/actors/targets/browsing-context.js
--- a/devtools/server/actors/targets/browsing-context.js
+++ b/devtools/server/actors/targets/browsing-context.js
@@ -1187,39 +1187,31 @@ const browsingContextTargetPrototype = {
    */
   preNest() {
     if (!this.window) {
       // The browsing context is already closed.
       return;
     }
     const windowUtils = this.window.windowUtils;
 
-    // Events are not suppressed when running in the middleman, as we are in a
-    // different process from the debuggee and may want to process events in
-    // the middleman for e.g. the overlay drawn when rewinding.
-    if (Debugger.recordReplayProcessKind() != "Middleman") {
-      windowUtils.suppressEventHandling(true);
-    }
-
+    windowUtils.suppressEventHandling(true);
     windowUtils.suspendTimeouts();
   },
 
   /**
    * Prepare to exit a nested event loop by enabling debuggee events.
    */
   postNest(nestData) {
     if (!this.window) {
       // The browsing context is already closed.
       return;
     }
     const windowUtils = this.window.windowUtils;
     windowUtils.resumeTimeouts();
-    if (Debugger.recordReplayProcessKind() != "Middleman") {
-      windowUtils.suppressEventHandling(false);
-    }
+    windowUtils.suppressEventHandling(false);
   },
 
   _changeTopLevelDocument(window) {
     // Fake a will-navigate on the previous document
     // to let a chance to unregister it
     this._willNavigate(this.window, window.location.href, null, true);
 
     this._windowDestroyed(this.window, null, true);