Bug 842471 - Invalid value type in BluetoothDevicePropertiesRunnable(), r=echou
authorGina Yeh <gyeh@mozilla.com>
Wed, 20 Feb 2013 14:19:34 +0800
changeset 122402 462b9501603dfe30a166ae40eebc070f8e307604
parent 122401 49a58331057341affcf17051a0b2cf412e04d51c
child 122403 c9840572966bf99aedd7f1cb42d8df6f27be5654
push id23276
push usergyeh@mozilla.com
push dateWed, 20 Feb 2013 06:19:55 +0000
treeherdermozilla-inbound@462b9501603d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersechou
bugs842471
milestone22.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 842471 - Invalid value type in BluetoothDevicePropertiesRunnable(), r=echou
dom/bluetooth/linux/BluetoothDBusService.cpp
--- a/dom/bluetooth/linux/BluetoothDBusService.cpp
+++ b/dom/bluetooth/linux/BluetoothDBusService.cpp
@@ -1450,25 +1450,18 @@ EventFilter(DBusConnection* aConn, DBusM
                                DBUS_TYPE_OBJECT_PATH, &str,
                                DBUS_TYPE_INVALID)) {
       LOG_AND_FREE_DBUS_ERROR_WITH_MSG(&err, aMsg);
       errorStr.AssignLiteral("Cannot parse device path!");
     } else {
       v = NS_ConvertUTF8toUTF16(str);
     }
 
-    BluetoothSignal signal(signalName, signalPath, v);
-
-    // Fire a Device properties fetcher at the main thread
-    nsRefPtr<DevicePropertiesSignalHandler> b =
-      new DevicePropertiesSignalHandler(signal);
-    if (NS_FAILED(NS_DispatchToMainThread(b))) {
-      NS_WARNING("Failed to dispatch to main thread!");
-    }
-    // Since we're handling this in other threads, just fall out here
+    // Bug 842471. No need to get device properties here and forward to
+    // BluetoothAdapter, and this event is going to be removed from idl.
     return DBUS_HANDLER_RESULT_HANDLED;
   } else if (dbus_message_is_signal(aMsg, DBUS_ADAPTER_IFACE, "DeviceRemoved")) {
     const char* str;
     if (!dbus_message_get_args(aMsg, &err,
                                DBUS_TYPE_OBJECT_PATH, &str,
                                DBUS_TYPE_INVALID)) {
       LOG_AND_FREE_DBUS_ERROR_WITH_MSG(&err, aMsg);
       errorStr.AssignLiteral("Cannot parse device path!");