Bug 1469265 [wpt PR 11547] - Do not override kReattach for ::first-letter., a=testonly
authorRune Lillesveen <futhark@chromium.org>
Fri, 06 Jul 2018 17:31:54 +0000
changeset 425835 4465412a5b1b22d3540decb90515c3d58e7c3d62
parent 425834 bdc728cacbec3cf45749e4f9c7e898c52a01b8ec
child 425836 5b8090a38193f68cdcb5ec3c4789838f8e0de363
push id105141
push userjames@hoppipolla.co.uk
push dateWed, 11 Jul 2018 07:44:38 +0000
treeherdermozilla-inbound@b06fa226ba6d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1469265, 11547, 853621, 853476, 853471, 853470, 853433, 853411, 1104176, 568006
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1469265 [wpt PR 11547] - Do not override kReattach for ::first-letter., a=testonly Automatic update from web-platform-testsDo not override kReattach for ::first-letter. We incorrectly did an override with kForce for ::first-letter recalc when we were already recalculating style for re-attachment (kReattach). This caused crashes in FirstLetterPseudoElement::DidRecalcStyle. Bug: 853621, 853476, 853471, 853470, 853433, 853411 Change-Id: Id34e6bdbaaeb3b4933a3e963b68f0bffcda0e40e Reviewed-on: https://chromium-review.googlesource.com/1104176 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#568006} -- wpt-commits: 92bb4ac55a7943cb31d5265dc99c427f4fd07d98 wpt-pr: 11547
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/css/css-pseudo/first-letter-block-to-inline-ref.html
testing/web-platform/tests/css/css-pseudo/first-letter-block-to-inline.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -127174,16 +127174,28 @@
       [
        "/css/css-pseudo/first-letter-004-ref.html",
        "=="
       ]
      ],
      {}
     ]
    ],
+   "css/css-pseudo/first-letter-block-to-inline.html": [
+    [
+     "/css/css-pseudo/first-letter-block-to-inline.html",
+     [
+      [
+       "/css/css-pseudo/first-letter-block-to-inline-ref.html",
+       "=="
+      ]
+     ],
+     {}
+    ]
+   ],
    "css/css-pseudo/first-line-and-placeholder.html": [
     [
      "/css/css-pseudo/first-line-and-placeholder.html",
      [
       [
        "/css/css-pseudo/first-line-and-placeholder-ref.html",
        "=="
       ]
@@ -253630,16 +253642,21 @@
      {}
     ]
    ],
    "css/css-pseudo/first-letter-004-ref.html": [
     [
      {}
     ]
    ],
+   "css/css-pseudo/first-letter-block-to-inline-ref.html": [
+    [
+     {}
+    ]
+   ],
    "css/css-pseudo/first-line-and-placeholder-ref.html": [
     [
      {}
     ]
    ],
    "css/css-pseudo/marker-and-other-pseudo-elements-ref.html": [
     [
      {}
@@ -523723,16 +523740,24 @@
   "css/css-pseudo/first-letter-004-ref.html": [
    "4387a0cec6417a73b99caa4482eaf343921ce285",
    "support"
   ],
   "css/css-pseudo/first-letter-004.html": [
    "5a7a51802925bda01fbb62c8635a0e3205683e51",
    "reftest"
   ],
+  "css/css-pseudo/first-letter-block-to-inline-ref.html": [
+   "1c8ca71127b09dc729377b71b102bed8095aa249",
+   "support"
+  ],
+  "css/css-pseudo/first-letter-block-to-inline.html": [
+   "7bc7db3195b26fb32ca3b01a5834a90af66987a8",
+   "reftest"
+  ],
   "css/css-pseudo/first-letter-property-whitelist.html": [
    "38d0844f6ef10d214b7d23af45d02c8093d9c00e",
    "testharness"
   ],
   "css/css-pseudo/first-line-and-placeholder-ref.html": [
    "b1aaba95588025ae60b324f23cc14e3b0ef40836",
    "support"
   ],
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-pseudo/first-letter-block-to-inline-ref.html
@@ -0,0 +1,2 @@
+<!DOCTYPE html>
+<span style="color:green">This text should be green.</span>
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-pseudo/first-letter-block-to-inline.html
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<title>CSS Test: ::first-letter stops applying to element becoming inline.</title>
+<link rel="author" title="Rune Lillesveen" href="mailto:futhark@chromium.org">
+<link rel="match" href="first-letter-block-to-inline-ref.html">
+<link rel="help" href="https://drafts.csswg.org/css-pseudo-4/#first-letter-pseudo">
+<style>
+  #outer.block::first-letter { color: red }
+  #outer.block { display: block }
+</style>
+<span id="outer" class="block">
+  <span id="inner">This text should be green.</span>
+</span>
+<script>
+  outer.offsetTop;
+  outer.className = "";
+  inner.style.color = "green";
+</script>